From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752781AbdK3Mdi (ORCPT ); Thu, 30 Nov 2017 07:33:38 -0500 Received: from mail-eopbgr10138.outbound.protection.outlook.com ([40.107.1.138]:45373 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752538AbdK3Mdg (ORCPT ); Thu, 30 Nov 2017 07:33:36 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; From: Andrey Ryabinin To: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org Cc: linux-kernel@vger.kernel.org, Josh Poimboeuf , Alexander Potapenko , Dmitry Vyukov , xiaolong.ye@intel.com, fengguang.wu@intel.com, Andrey Ryabinin Subject: [PATCH] x86/unwind_guess: Prevent using UNWINDER_GUESS=y with STACKDEPOT=y Date: Thu, 30 Nov 2017 15:35:54 +0300 Message-Id: <20171130123554.4330-1-aryabinin@virtuozzo.com> X-Mailer: git-send-email 2.13.6 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: HE1P189CA0033.EURP189.PROD.OUTLOOK.COM (2603:10a6:7:53::46) To VI1PR08MB2831.eurprd08.prod.outlook.com (2603:10a6:802:19::28) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 40061a25-8fe1-4d71-70ce-08d537ee9159 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(7168020)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603285);SRVR:VI1PR08MB2831; X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB2831;3:e/GVYjrPOkXRplMGqjVCd5xMNxoL65WYXjHNVe+I7kMXP8JQKQyraz2D+NMeqr1VlF+NI2axZTHMC+MwoCcmOc+a43oZdyuoyKbH90y7S3PEBE/h+WgKo1MWtriNeF6fgEgQfv2piXnnP2Z5cQ66R5KG1TXQPiPO5SvHs0Ts5vZFG4dEkeIQzyGmskAZK0EUJ6WpUnuvlQFU7CRxTZL7G2/6CClk8NBvgjLw7zpb3yknOtJlsMrltEG7qfkM6Ajl;25:wsl62RSgH88m43y/GU34sf36VebMItvKE8fxiT4W1dzyGNT9D0BqRLrDrn33/eNCnHTlGhI/6mm0oOOsnBss9dH4r+aHte3PxhTegEoJK6smsKIMRQFEENnZbF8NoFGieFFxcjmlLQMTls2GgH1bRRLdbZkT6k5Il9f2h2wfMaeRd5ylV8CAlMMZVbjcxNzAa3RBveNEbhPMjo1F65iXmsb18935Tp3clee+syakc9IseAHiN6SXUNtyvu8KiFK7g+5Mw0oV82/QofjgPrJuKQpvVTxiyBlvW1kgVC2pJXmjjx2ptW1r7MDF44oCCWhFpJ9NPMJ6SWTJ/ze0aOO/E5fS1kUIZshhjlpRwSOcJ+k=;31:EJj9cFkYgwKQpwOEw741TdWhWUouSGUTPWGaXrCuzz6GMg0CBwvf34sEnh1iVVhN+hvnq8f0oB9OVA8W1givpH9rrJ4KN60VsqrKI8cMNKqFBtBkDOXGMfmHjEt/lU7MECq10q2/9lWUEvUTBbYtTR0hkD3N9RDz451d7BaUZu/47gDc4iNYKgIHItzd6J/qxPzgnsW2IVzXV027ZgTDFgRBvpX1bWp8MCrBpcvNYW8= X-MS-TrafficTypeDiagnostic: VI1PR08MB2831: X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB2831;20:RvFuFwKqAptxNAQQpTFXJLcw99dalkim+VJvb4bC9GM73z0YMuPoeguRe+SwTacDZPNihH+n5aHwPyLRWz2z840c/FdksFn0Te/RFIKy/Gm9F2C8RAbOHiu7YoI1wp12Xf7Jwmwewi+T+l+8S4v2V1ty+NiApOID2VGpEDZ26gyckssA3D61LS+/UFvCF2mAwVd9wFMx3cl7EdF4u3EY9A1CKZmEigdO+6M3I8VkVBsu+Gla3OJonJMTVydg8cuaqxJWYHfKWOHJCwc/luSYDahadPPDYDYoS92p1sNzyJI1MmgqU5307YTZbul337efBcCF9Q6ukozdkFyuVWBYIVXSFAVbo8j+p2UudX/2CbQ5GgwitJ1IweKOme1gp07uZUpI5vX7j/xOBXs9wt1mCNTBZxZ6pWeiaLTuZjGVo9I=;4:ylvZrggl7z2i3whnZUqoyrH8TrgbjsxUUcmN14m+biaAHP8RA5j1IRsVUosSY9m3TmMwNAIcx26Vk3J07/RghB7fQslIn6SVgXzcSmMyqS04gip+8I1ItelXnMoRnZBob/u/HSjvrm5OtBa4oqBHwtfiZPdawyhcPlNwT52moZfbihg3lProPn7YVy+5MgEEI1VxWupo4FMk15bCPN545L1C/5FcuLLjaF6HzzbqD5u3RaOBv8pki5Z5NA6H2vRmCJ6Kc7zSDN+xfEal9XForUwArHHCDP21NsjIJKk2UWp92Txm4jcqQ/1LcRSXMw/3+baVQpnIxcbNYoLQ9HS4wMF5uX5tFlr163ynazZJesY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(20558992708506)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231022)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123562025)(20161123564025)(6072148)(201708071742011);SRVR:VI1PR08MB2831;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:VI1PR08MB2831; X-Forefront-PRVS: 05079D8470 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6069001)(6009001)(376002)(346002)(366004)(189002)(199003)(1076002)(53936002)(47776003)(50226002)(6116002)(50466002)(66066001)(4326008)(7416002)(81166006)(16526018)(101416001)(33646002)(68736007)(25786009)(50986010)(53416004)(478600001)(6666003)(2906002)(76506005)(48376002)(86362001)(6512007)(105586002)(6506006)(189998001)(8676002)(5660300001)(69596002)(55236003)(106356001)(36756003)(6486002)(51416003)(54906003)(52116002)(97736004)(305945005)(8936002)(3846002)(81156014)(110136005)(7736002)(16586007)(316002)(107886003);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR08MB2831;H:localhost.sw.ru;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR08MB2831;23:1rAJA6gi/WD6QGPWh2UMVodpRaAW9fx16Z8ZWZQ8B?= =?us-ascii?Q?8D/ZKBHfnmzK/nPzrqwcjzLitJt7o0sWWaXWyY9HqIkdTU1M/13U5ctD9H0P?= =?us-ascii?Q?cp9wqdIAkPJ2YDN9b/0WEGvtVPKXm5rYMNegDCpbv94DckQl+Bcp/fnth1YI?= =?us-ascii?Q?wPY74yla21vcx4dkNyOVxSa0AUOUpTR5HvhdV1WxllXbU0sjrrJFLBTngR29?= =?us-ascii?Q?YBJr3KUUXyKXZWoAOe4pXbnCWwrlv3Yu4AefJ2v1ozHlh0CAcYgRWP3DJgwA?= =?us-ascii?Q?mgYzD+0vfZYKu1xkWYQd9Ak7SEtQakRxfwfOx1X8WgxI7G6eieXmyHOxerz3?= =?us-ascii?Q?lFiVW1YRiIHKgIihRxNJeBk4MuATr/72DdQ6KHLD+bPmN8i0dSpn8Eb7L8Sb?= =?us-ascii?Q?a8yA3tsgyical5hNo0jQ68Cclc/siKgGtMHg+wOs3qdHVpSC/qhyviagNKr4?= =?us-ascii?Q?j5NlqVbtW0En7vImbcj21ls4zPLW1mAcQYRioPTSDLy4iEaM+vZQTHzzHdbw?= =?us-ascii?Q?MPHjRpKf8NrWrGTzJZZZTCNStKwzoKB33SI8I2CoNLOl+oPqDfLXFI1c5mC9?= =?us-ascii?Q?0XZAl/pYUd/9Lu+9qeLljMchfbQRJ6DaN/uizSe+qLyA1yjIPJG0JrUYcdCC?= =?us-ascii?Q?hOomBwlgTXM/OHVVnsf5Bt55w4TGEG0sIr5cKfXo9dbJfDm0Yk6Ze9m8YHLl?= =?us-ascii?Q?IdQUBLkwm1BOS70oyWzLDURvQ7IfzDUBI6UyFl0FtQLy1USXm0K7iIjGkniH?= =?us-ascii?Q?DiVEyF9vKR0wB9joeJu1tSa66sc9S3EL4Tma8+FNOLH6K6X4Hh3DfJbrV59w?= =?us-ascii?Q?PzF0YBOcQ808UOb12fKJlgjpajnRBY5YM9coBXoC7n3FlS05uniKcPmCd8+u?= =?us-ascii?Q?HhpEuTdir9wR2fxGvI0Lg5a83zioJ+omA4cW+ZmhhzIgEwW65osYZeMKfVeX?= =?us-ascii?Q?U3nE4VYa5/WfUjkukFwqIf9xO/NyXbAd6t5dC068GrGnrzcskcZ9w1NDSt7N?= =?us-ascii?Q?yNJ4lovGWrl9b1UF5xUCKE513HcZrlntBvogb0GLQQ/PvQLyb898uplf61A+?= =?us-ascii?Q?xrx0PgYecD/oUp2dVDwkmihiuK1EszlnfY8zc4SjOy9WgfO/lFKDaBlR5N6X?= =?us-ascii?Q?QDoOIiui7VxZDzzJzqPUQpcFdpZBFOatb3KxUmilW07E0NGYTZogcxgEv3pc?= =?us-ascii?Q?RxIk0Hi5U3tA5XS8xgaWTMx7ae5gv5pzwcVsD0rD35I9Xf0KU06Jw6+EA=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB2831;6:BYhC40kQxZuTo1KaupVCNkVQJjJqinrw6sIVSleNpPez3JQWL0dqcbZUyJYYra5uc62V/EaFLeoeqn2bL/N+yF2Ci5ktM3Z+73fWBryO/ZXHC0RBa36gxCg+3BceqXS2vqkcMg5ncAAI9NAsEohHpEzqTVABSF522a2dLwRP+3UPNAGAmnKLwFeswBNbJXQ75AV1sKx0b5RGggCToZqDaBJE1VZ0L/vWH0jeobXJSyKNFGv1yA1suKv7zO+DAotNGUGYyyfFT9U5KMPNApZ3BlJjxWa6kFrrw6Jf+nmYTfm1zeHcJ5r1Mv25tza8VRkarRJt1iBAxVCvFoWjJNl1hWCozBQJJV7IpOrRooP78xs=;5:2fAj/Iz8fc01TKAWFtladYW/icMAVAqFysGfKyPdQc/OB0BjjJGV/RatcT/2/PmldveyuiogwmDIMUtYb2zhHjiBA9U8pu9npGH2IWpnz2ZmvCK8FtT0VUIhpPnnCVgPoYgHr5zhbuJA6yekZOohY3LTQ2OmfNTyCF9IiKGQOqk=;24:OFbjxvGTzjx0S8/hXh5IjpsBJKM/u4e5E6nqtRd5YmKkFffhGFoST2dOHeeo8llBuOlHXGGvpQWSOEIDB/ubk79PYU2BiLSdncw3GGbtYcM=;7:8Uhk3wCBSsgqyClw239Qc6955pi+yJvUrqoLyWSNg8mskW9OqmQhZdJPFx5opbXbdH/WPVPT8SblbpnfXBZOn/3WwEVYXlB5i1atmjs+Auj0V6P/PcmMt6aXBbSasAHHS8xH9PDFTCiH/alGxWm2cuOm9u1C8AFDTERr0gGETbvuF6XPlOhZafKy4/yHFDsghcbvgUnTY69itlrrxAv6bgMph0fA9gTDLHWCPF1yax0fvgh9XVvWfVGldNM+whEG SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB2831;20:NaAmiCznN4HgWp6TCvqArPcMeBChvZzNefTTb3SgPhfzYTu6kcA2KXGcwprHsiYqA9V13UEPcqmxRdIFUZMBUeo8Dfl8jCJ9O1aNnF6OiNMyqRMNLvCCrgmX2XyolyVBRnehHbdDyapi75JodAYL6F6a0HE5BIlIBIproXs17kU= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2017 12:33:31.4188 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 40061a25-8fe1-4d71-70ce-08d537ee9159 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2831 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stackdepot doesn't work well with CONFIG_UNWINDER_GUESS=y. The 'guess' unwinder generate awfully large and inaccurate stacktraces, thus stackdepot can't deduplicate stacktraces because they all look like unique. Eventually stackdepot reaches its capacity limit: WARNING: CPU: 0 PID: 545 at lib/stackdepot.c:119 depot_save_stack+0x28e/0x550 Call Trace: ? kasan_kmalloc+0x144/0x160 ? depot_save_stack+0x1f5/0x550 ? do_raw_spin_unlock+0xda/0xf0 ? preempt_count_sub+0x13/0xc0 <...90 lines...> ? do_raw_spin_unlock+0xda/0xf0 Add STACKDEPOT=n dependency to UNWINDER_GUESS to avoid the problem. Signed-off-by: Andrey Ryabinin Reported-by: kernel test robot Reported-by: Fengguang Wu --- arch/x86/Kconfig.debug | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug index 6293a8768a91..672441c008c7 100644 --- a/arch/x86/Kconfig.debug +++ b/arch/x86/Kconfig.debug @@ -400,6 +400,7 @@ config UNWINDER_FRAME_POINTER config UNWINDER_GUESS bool "Guess unwinder" depends on EXPERT + depends on !STACKDEPOT ---help--- This option enables the "guess" unwinder for unwinding kernel stack traces. It scans the stack and reports every kernel text address it -- 2.13.6