From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752795AbdK3Mws (ORCPT ); Thu, 30 Nov 2017 07:52:48 -0500 Received: from mail-yb0-f195.google.com ([209.85.213.195]:41207 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751099AbdK3Mwq (ORCPT ); Thu, 30 Nov 2017 07:52:46 -0500 X-Google-Smtp-Source: AGs4zMYnL8kitBY7ngs4wi9xGlSSK1Qjs9VcN0COla82Bpvj+g/21zSnm1eEZaJmDZl6xWskLeEojA== Date: Thu, 30 Nov 2017 07:52:42 -0500 From: Josh Abraham To: Dan Carpenter Cc: arnaud.patard@rtp-net.org, kstewart@linuxfoundation.org, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, pombredanne@nexb.com, tglx@linutronix.de Subject: Re: [PATCH] staging: xgifb: remove unused macro XGIPART3 Message-ID: <20171130125242.GA20957@josharch> References: <20171130025348.GA11487@josharch> <20171130055544.zumzsypzwzssozts@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171130055544.zumzsypzwzssozts@mwanda> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 30, 2017 at 08:55:44AM +0300, Dan Carpenter wrote: > On Wed, Nov 29, 2017 at 09:53:48PM -0500, Joshua Abraham wrote: > > Signed-off-by: Joshua Abraham > > > > This patch removes the unused macro XGIPART3. > > > > The Signed-off-by line goes after the changelog. > > > --- > > drivers/staging/xgifb/XGI_main.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/staging/xgifb/XGI_main.h b/drivers/staging/xgifb/XGI_main.h > > index a3af1cbbf8ee..5f55d0a39bc1 100644 > > --- a/drivers/staging/xgifb/XGI_main.h > > +++ b/drivers/staging/xgifb/XGI_main.h > > @@ -25,7 +25,6 @@ MODULE_DEVICE_TABLE(pci, xgifb_pci_table); > > #define XGIDACD (xgifb_info->dev_info.P3c9) > > #define XGIPART1 (xgifb_info->dev_info.Part1Port) > > #define XGIPART2 (xgifb_info->dev_info.Part2Port) > > -#define XGIPART3 (xgifb_info->dev_info.Part3Port) > > That define isn't hurting anyone. > > > #define XGIPART4 (xgifb_info->dev_info.Part4Port) > > #define XGIPART5 (xgifb_info->dev_info.Part5Port) > > Actually these should all be deleted because they mean you have to have > a xgifb_info variable and they hurt readability by hiding stuff behind a > define. It would be better to remove them all than to just remove one > from the middle. That's a more complicated patch, but it's a useful > patch. > > regards, > dan carpenter > Great point. I will work on that and get the patch out! -Josh