From: Tony Lindgren <tony@atomide.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Tomi Valkeinen" <tomi.valkeinen@ti.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"David Airlie" <airlied@linux.ie>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Russell King" <linux@armlinux.org.uk>,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Julia Lawall" <Julia.Lawall@lip6.fr>,
"Sean Paul" <seanpaul@chromium.org>,
dri-devel@lists.freedesktop.org,
DTML <devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
linux-fbdev@vger.kernel.org,
"Discussions about the Letux Kernel"
<letux-kernel@openphoenux.org>,
kernel@pyra-handheld.com
Subject: Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string
Date: Thu, 30 Nov 2017 07:24:30 -0800 [thread overview]
Message-ID: <20171130152430.GM28152@atomide.com> (raw)
In-Reply-To: <4EE1E298-6461-48FF-977C-958DD16AD83A@goldelico.com>
* H. Nikolaus Schaller <hns@goldelico.com> [171128 18:35]:
> Hi,
>
> > Am 28.11.2017 um 17:18 schrieb Tony Lindgren <tony@atomide.com>:
> >
> > * H. Nikolaus Schaller <hns@goldelico.com> [171128 16:17]:
> >> Hi Tony,
> >>
> >>> Am 28.11.2017 um 17:04 schrieb Tony Lindgren <tony@atomide.com>:
> >>>
> >>> * H. Nikolaus Schaller <hns@goldelico.com> [171128 15:52]:
> >>>> We can remove the unnecessary "omapdss," prefix because
> >>>> the omapdrm driver takes care of it when matching with
> >>>> the driver table.
> >>>
> >>> So is this needed as a fix or is this another clean-up?
> >>>
> >>> So is this is really needed as a fix?
> >>
> >> Hm. How do you differentiate between "fix" and "cleanup"?
> >> Maybe it is more a wording than a content issue...
> >>
> >> For me it is a "fix" because it is semantically wrong to have
> >> a prefix where it is not needed. And "fixing" it changes the
> >> compiler output by 8 bytes.
> >
> > How about let's call it a "typo fix" then? :)
>
> Well, it is not really a typo.
Well what if the stable people pick it into earlier stable series
based on the word fix in the subject? That has happened before.
I suggest you update the dts patches to use wording like
"update compatible to use new naming" or something similar.
Regards,
Tony
next prev parent reply other threads:[~2017-11-30 15:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 15:48 [PATCH v3 0/4] Fixes for omapdrm on OpenPandora and GTA04 H. Nikolaus Schaller
2017-11-28 15:48 ` [PATCH v3 1/4] omapdrm: panel: fix compatible vendor string for td028ttec1 H. Nikolaus Schaller
2017-12-01 1:57 ` Rob Herring
2017-12-01 7:46 ` H. Nikolaus Schaller
2017-12-01 8:18 ` Tomi Valkeinen
2017-11-28 15:48 ` [PATCH v3 2/4] omapdrm: panel: td028ttec1: replace MODULE_ALIAS by MODULE_DEVICE_TABLE H. Nikolaus Schaller
2017-11-28 15:48 ` [PATCH v3 3/4] DTS: GTA04: fix panel compatibility string H. Nikolaus Schaller
2017-11-28 16:02 ` Tony Lindgren
2017-11-28 15:48 ` [PATCH v3 4/4] DTS: Pandora: " H. Nikolaus Schaller
2017-11-28 16:04 ` Tony Lindgren
2017-11-28 16:14 ` H. Nikolaus Schaller
2017-11-28 16:18 ` Tony Lindgren
[not found] ` <4EE1E298-6461-48FF-977C-958DD16AD83A@goldelico.com>
2017-11-30 15:24 ` Tony Lindgren [this message]
2017-11-30 22:06 ` Sebastian Reichel
2017-12-01 8:13 ` Tomi Valkeinen
2017-12-01 9:48 ` H. Nikolaus Schaller
2017-12-01 10:01 ` Tomi Valkeinen
2017-12-11 15:16 ` Tony Lindgren
2017-12-01 7:41 ` H. Nikolaus Schaller
2017-11-30 10:54 ` [PATCH v3 0/4] Fixes for omapdrm on OpenPandora and GTA04 Tomi Valkeinen
2017-11-30 15:27 ` Tony Lindgren
2017-12-01 17:22 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130152430.GM28152@atomide.com \
--to=tony@atomide.com \
--cc=Julia.Lawall@lip6.fr \
--cc=airlied@linux.ie \
--cc=b.zolnierkie@samsung.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=kernel@pyra-handheld.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=seanpaul@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).