* [PATCH 1/2] thermal: mtk: Cleanup unused defines
@ 2017-12-01 10:43 Matthias Brugger
2017-12-14 11:21 ` Matthias Brugger
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Matthias Brugger @ 2017-12-01 10:43 UTC (permalink / raw)
To: rui.zhang, edubezval
Cc: matthias.bgg, linux-pm, linux-arm-kernel, linux-mediatek,
linux-kernel, Matthias Brugger
The mtk_thermal has some defiens which are never used within the driver.
This patch delets them.
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
drivers/thermal/mtk_thermal.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
index 1e61c09153c9..c75661a3801a 100644
--- a/drivers/thermal/mtk_thermal.c
+++ b/drivers/thermal/mtk_thermal.c
@@ -32,15 +32,10 @@
#include <linux/types.h>
/* AUXADC Registers */
-#define AUXADC_CON0_V 0x000
-#define AUXADC_CON1_V 0x004
#define AUXADC_CON1_SET_V 0x008
#define AUXADC_CON1_CLR_V 0x00c
#define AUXADC_CON2_V 0x010
#define AUXADC_DATA(channel) (0x14 + (channel) * 4)
-#define AUXADC_MISC_V 0x094
-
-#define AUXADC_CON1_CHANNEL(x) BIT(x)
#define APMIXED_SYS_TS_CON1 0x604
@@ -158,8 +153,6 @@
/* The number of sensing points per bank */
#define MT2712_NUM_SENSORS_PER_ZONE 4
-#define THERMAL_NAME "mtk-thermal"
-
struct mtk_thermal;
struct thermal_bank_cfg {
@@ -765,7 +758,7 @@ static struct platform_driver mtk_thermal_driver = {
.probe = mtk_thermal_probe,
.remove = mtk_thermal_remove,
.driver = {
- .name = THERMAL_NAME,
+ .name = "mtk-thermal",
.of_match_table = mtk_thermal_of_match,
},
};
--
2.12.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] thermal: mtk: Cleanup unused defines
2017-12-01 10:43 [PATCH 1/2] thermal: mtk: Cleanup unused defines Matthias Brugger
@ 2017-12-14 11:21 ` Matthias Brugger
2017-12-14 11:26 ` Daniel Lezcano
2017-12-21 10:01 ` Matthias Brugger
2 siblings, 0 replies; 6+ messages in thread
From: Matthias Brugger @ 2017-12-14 11:21 UTC (permalink / raw)
To: rui.zhang, edubezval
Cc: linux-pm, linux-arm-kernel, linux-mediatek, linux-kernel,
Matthias Brugger
On 12/01/2017 11:43 AM, Matthias Brugger wrote:
> The mtk_thermal has some defiens which are never used within the driver.
> This patch delets them.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---
> drivers/thermal/mtk_thermal.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 1e61c09153c9..c75661a3801a 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -32,15 +32,10 @@
> #include <linux/types.h>
>
> /* AUXADC Registers */
> -#define AUXADC_CON0_V 0x000
> -#define AUXADC_CON1_V 0x004
> #define AUXADC_CON1_SET_V 0x008
> #define AUXADC_CON1_CLR_V 0x00c
> #define AUXADC_CON2_V 0x010
> #define AUXADC_DATA(channel) (0x14 + (channel) * 4)
> -#define AUXADC_MISC_V 0x094
> -
> -#define AUXADC_CON1_CHANNEL(x) BIT(x)
>
> #define APMIXED_SYS_TS_CON1 0x604
>
> @@ -158,8 +153,6 @@
> /* The number of sensing points per bank */
> #define MT2712_NUM_SENSORS_PER_ZONE 4
>
> -#define THERMAL_NAME "mtk-thermal"
> -
> struct mtk_thermal;
>
> struct thermal_bank_cfg {
> @@ -765,7 +758,7 @@ static struct platform_driver mtk_thermal_driver = {
> .probe = mtk_thermal_probe,
> .remove = mtk_thermal_remove,
> .driver = {
> - .name = THERMAL_NAME,
> + .name = "mtk-thermal",
> .of_match_table = mtk_thermal_of_match,
> },
> };
>
Kind ping.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] thermal: mtk: Cleanup unused defines
2017-12-01 10:43 [PATCH 1/2] thermal: mtk: Cleanup unused defines Matthias Brugger
2017-12-14 11:21 ` Matthias Brugger
@ 2017-12-14 11:26 ` Daniel Lezcano
2017-12-21 10:01 ` Matthias Brugger
2 siblings, 0 replies; 6+ messages in thread
From: Daniel Lezcano @ 2017-12-14 11:26 UTC (permalink / raw)
To: Matthias Brugger, rui.zhang, edubezval
Cc: linux-pm, linux-arm-kernel, linux-mediatek, linux-kernel,
Matthias Brugger
On 01/12/2017 11:43, Matthias Brugger wrote:
> The mtk_thermal has some defiens which are never used within the driver.
> This patch delets them.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] thermal: mtk: Cleanup unused defines
2017-12-01 10:43 [PATCH 1/2] thermal: mtk: Cleanup unused defines Matthias Brugger
2017-12-14 11:21 ` Matthias Brugger
2017-12-14 11:26 ` Daniel Lezcano
@ 2017-12-21 10:01 ` Matthias Brugger
2017-12-21 13:40 ` Zhang Rui
2 siblings, 1 reply; 6+ messages in thread
From: Matthias Brugger @ 2017-12-21 10:01 UTC (permalink / raw)
To: rui.zhang, edubezval
Cc: linux-pm, linux-arm-kernel, linux-mediatek, linux-kernel,
Matthias Brugger
On 12/01/2017 11:43 AM, Matthias Brugger wrote:
> The mtk_thermal has some defiens which are never used within the driver.
> This patch delets them.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---
Rui, Eduardo, do you have any comments on this patch?
Regards,
Matthias
> drivers/thermal/mtk_thermal.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 1e61c09153c9..c75661a3801a 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -32,15 +32,10 @@
> #include <linux/types.h>
>
> /* AUXADC Registers */
> -#define AUXADC_CON0_V 0x000
> -#define AUXADC_CON1_V 0x004
> #define AUXADC_CON1_SET_V 0x008
> #define AUXADC_CON1_CLR_V 0x00c
> #define AUXADC_CON2_V 0x010
> #define AUXADC_DATA(channel) (0x14 + (channel) * 4)
> -#define AUXADC_MISC_V 0x094
> -
> -#define AUXADC_CON1_CHANNEL(x) BIT(x)
>
> #define APMIXED_SYS_TS_CON1 0x604
>
> @@ -158,8 +153,6 @@
> /* The number of sensing points per bank */
> #define MT2712_NUM_SENSORS_PER_ZONE 4
>
> -#define THERMAL_NAME "mtk-thermal"
> -
> struct mtk_thermal;
>
> struct thermal_bank_cfg {
> @@ -765,7 +758,7 @@ static struct platform_driver mtk_thermal_driver = {
> .probe = mtk_thermal_probe,
> .remove = mtk_thermal_remove,
> .driver = {
> - .name = THERMAL_NAME,
> + .name = "mtk-thermal",
> .of_match_table = mtk_thermal_of_match,
> },
> };
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] thermal: mtk: Cleanup unused defines
2017-12-21 10:01 ` Matthias Brugger
@ 2017-12-21 13:40 ` Zhang Rui
2018-01-01 19:56 ` Eduardo Valentin
0 siblings, 1 reply; 6+ messages in thread
From: Zhang Rui @ 2017-12-21 13:40 UTC (permalink / raw)
To: Matthias Brugger, edubezval
Cc: linux-pm, linux-arm-kernel, linux-mediatek, linux-kernel,
Matthias Brugger
On Thu, 2017-12-21 at 11:01 +0100, Matthias Brugger wrote:
>
> On 12/01/2017 11:43 AM, Matthias Brugger wrote:
> >
> > The mtk_thermal has some defiens which are never used within the
> > driver.
> > This patch delets them.
> >
> > Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> > ---
> Rui, Eduardo, do you have any comments on this patch?
>
No, I don't have any.
I suppose Eduardo will review them soon as I need the thermal soc
material for next merge window.
thanks,
rui
> Regards,
> Matthias
>
> >
> > drivers/thermal/mtk_thermal.c | 9 +--------
> > 1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > diff --git a/drivers/thermal/mtk_thermal.c
> > b/drivers/thermal/mtk_thermal.c
> > index 1e61c09153c9..c75661a3801a 100644
> > --- a/drivers/thermal/mtk_thermal.c
> > +++ b/drivers/thermal/mtk_thermal.c
> > @@ -32,15 +32,10 @@
> > #include <linux/types.h>
> >
> > /* AUXADC Registers */
> > -#define AUXADC_CON0_V 0x000
> > -#define AUXADC_CON1_V 0x004
> > #define AUXADC_CON1_SET_V 0x008
> > #define AUXADC_CON1_CLR_V 0x00c
> > #define AUXADC_CON2_V 0x010
> > #define AUXADC_DATA(channel) (0x14 + (channel) * 4)
> > -#define AUXADC_MISC_V 0x094
> > -
> > -#define AUXADC_CON1_CHANNEL(x) BIT(x)
> >
> > #define APMIXED_SYS_TS_CON1 0x604
> >
> > @@ -158,8 +153,6 @@
> > /* The number of sensing points per bank */
> > #define MT2712_NUM_SENSORS_PER_ZONE 4
> >
> > -#define THERMAL_NAME "mtk-thermal"
> > -
> > struct mtk_thermal;
> >
> > struct thermal_bank_cfg {
> > @@ -765,7 +758,7 @@ static struct platform_driver
> > mtk_thermal_driver = {
> > .probe = mtk_thermal_probe,
> > .remove = mtk_thermal_remove,
> > .driver = {
> > - .name = THERMAL_NAME,
> > + .name = "mtk-thermal",
> > .of_match_table = mtk_thermal_of_match,
> > },
> > };
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] thermal: mtk: Cleanup unused defines
2017-12-21 13:40 ` Zhang Rui
@ 2018-01-01 19:56 ` Eduardo Valentin
0 siblings, 0 replies; 6+ messages in thread
From: Eduardo Valentin @ 2018-01-01 19:56 UTC (permalink / raw)
To: Zhang Rui
Cc: Matthias Brugger, linux-pm, linux-arm-kernel, linux-mediatek,
linux-kernel, Matthias Brugger
On Thu, Dec 21, 2017 at 09:40:13PM +0800, Zhang Rui wrote:
> On Thu, 2017-12-21 at 11:01 +0100, Matthias Brugger wrote:
> >
> > On 12/01/2017 11:43 AM, Matthias Brugger wrote:
> > >
> > > The mtk_thermal has some defiens which are never used within the
> > > driver.
> > > This patch delets them.
> > >
> > > Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> > > ---
> > Rui, Eduardo, do you have any comments on this patch?
> >
> No, I don't have any.
> I suppose Eduardo will review them soon as I need the thermal soc
> material for next merge window.
Yeah, I will be queueing this soon.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-01 19:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-01 10:43 [PATCH 1/2] thermal: mtk: Cleanup unused defines Matthias Brugger
2017-12-14 11:21 ` Matthias Brugger
2017-12-14 11:26 ` Daniel Lezcano
2017-12-21 10:01 ` Matthias Brugger
2017-12-21 13:40 ` Zhang Rui
2018-01-01 19:56 ` Eduardo Valentin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).