From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752783AbdLANhc (ORCPT <rfc822;w@1wt.eu>);
        Fri, 1 Dec 2017 08:37:32 -0500
Received: from heliosphere.sirena.org.uk ([172.104.155.198]:60498 "EHLO
        heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752488AbdLANha (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 1 Dec 2017 08:37:30 -0500
Date: Fri, 1 Dec 2017 13:37:23 +0000
From: Mark Brown <broonie@kernel.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        =?iso-8859-1?Q?Beno=EEt?= Cousson <bcousson@baylibre.com>,
        Tony Lindgren <tony@atomide.com>, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 15/19] ASoC: tlv320aic31xx: Reset registers during
 power up
Message-ID: <20171201133723.vlxqci4paw7szjce@sirena.org.uk>
References: <20171129213300.20021-1-afd@ti.com>
 <20171129213300.20021-16-afd@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="hd5vczuwjnxdaxvf"
Content-Disposition: inline
In-Reply-To: <20171129213300.20021-16-afd@ti.com>
X-Cookie: "I am, therefore I am."
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--hd5vczuwjnxdaxvf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Nov 29, 2017 at 03:32:56PM -0600, Andrew F. Davis wrote:

> +		gpiod_set_value(aic31xx->gpio_reset, 1);
> +		ndelay(10); /* At least 10ns */
> +		gpiod_set_value(aic31xx->gpio_reset, 0);

_cansleep(), this isn't being done from interrupt context.

> +	} else {
> +		ret = regmap_write(aic31xx->regmap, AIC31XX_RESET, 1);
> +		if (ret < 0)
> +			dev_err(aic31xx->dev, "Could not reset device\n");

Print the error to help people doing debug.

--hd5vczuwjnxdaxvf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlohWxMACgkQJNaLcl1U
h9B9kQf+Ki3cGrbVjouLiV7OqgE6Xk6UmVuiw0UgJe4lUVq1LZw1Sy4AUF4vnbRy
db0qZT8+zZvx77S3FRam4Nw9BLM1dYlxV+wUkTnRw4LKcXSC8e9uIz58vi/tNhcb
iK/yXdpE8OL4S0nkw2BCvYT4V7SbpHDK7coE5XkDa+29IbRq13hpG44M87z7ZBXO
0Oiu5DQqC43YvKpf67WlfahvgS1M6RKFYwsjIkxZZeMrRRB9CsKgfTN3Xj8pJscQ
nXW8FhE30ccvZKC3rgWWo2gFIz4aQkX4Pl9Zz1lHe0lZDwTuh1mdHg6rEdK38l6z
Ov5EIDpxS9TOaKPaV+pmi/IQ4PMPEA==
=wltU
-----END PGP SIGNATURE-----

--hd5vczuwjnxdaxvf--