* Re: Null pointer 4.14.1-rt3
[not found] ` <20171130113533.4485d894@gandalf.local.home>
@ 2017-12-01 12:26 ` Sebastian Andrzej Siewior
2017-12-01 16:03 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Andrzej Siewior @ 2017-12-01 12:26 UTC (permalink / raw)
To: Steven Rostedt, Peter Zijlstra, Ingo Molnar
Cc: Daniel Wagner, linux-rt-users, linux-kernel
On 2017-11-30 11:35:33 [-0500], Steven Rostedt wrote:
> Hmm, I'm not sure I tested this on a UP machine. Perhaps I should boot
> with CPUs=1
It does not crash everywhere. For instance Dra7x, imx6 do not crash
because they have GICv3 which does set required SMP function even on UP
systems. BBB which uses the ti,am33xx-intc / INTC does not and here we
boom.
>From what I see (in qemu) it won't explode on a x86-SMP config with one
CPU either because it sets that function, too (on APIC).
For RT it is enough to start one cyclictest. For !RT it looks to be
enough to enable SW-Watchdog and RCU boosting and I see
pull_rt_task() -> tell_cpu_to_push -> irq_work_queue_on()
on v4.14.2 with "sched/rt: Simplify the IPI based RT balancing logic"
Now, what do we do about it?
- does it make sense to tell tell_cpu_to_push() to not do anything if
the target CPU is the same as the current?
- irq_work_queue() uses arch_irq_work_raise() which has a check (on ARM)
and uses it only if it is really on SMP. The other user of
arch_send_call_function_single_ipi() is generic_exec_single() and this
one skips the invocation if target CPU == current CPU and invokes the
function directly. We could invoke arch_irq_work_raise() instead for
"local" case.
- disable RT_PUSH_IPI if booted on UP. After all there is not much
benefit here, is there?
- make a requirement for working arch_send_call_function_single_ipi()
but I guess invoking code for no reason make no sense.
Sebastian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Null pointer 4.14.1-rt3
2017-12-01 12:26 ` Null pointer 4.14.1-rt3 Sebastian Andrzej Siewior
@ 2017-12-01 16:03 ` Steven Rostedt
2017-12-01 16:38 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2017-12-01 16:03 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: Peter Zijlstra, Ingo Molnar, Daniel Wagner, linux-rt-users, linux-kernel
On Fri, 1 Dec 2017 13:26:05 +0100
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> - disable RT_PUSH_IPI if booted on UP. After all there is not much
> benefit here, is there?
This is what I would suggest. Maybe I'll look at adding a patch.
-- Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Null pointer 4.14.1-rt3
2017-12-01 16:03 ` Steven Rostedt
@ 2017-12-01 16:38 ` Sebastian Andrzej Siewior
0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Andrzej Siewior @ 2017-12-01 16:38 UTC (permalink / raw)
To: Steven Rostedt
Cc: Peter Zijlstra, Ingo Molnar, Daniel Wagner, linux-rt-users, linux-kernel
On 2017-12-01 11:03:15 [-0500], Steven Rostedt wrote:
> On Fri, 1 Dec 2017 13:26:05 +0100
> Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
>
> > - disable RT_PUSH_IPI if booted on UP. After all there is not much
> > benefit here, is there?
>
> This is what I would suggest. Maybe I'll look at adding a patch.
Please tag it stable because the patch made it into v4.14.3.
> -- Steve
Sebastian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-01 16:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <80ce7c3e-2d01-f082-9c21-fc1084a836c8@monom.org>
[not found] ` <8c913cc2-b2e3-8c2e-e503-aff1428f8ff5@monom.org>
[not found] ` <20171130112232.4c0cb600@gandalf.local.home>
[not found] ` <20171130162433.GG11362@linutronix.de>
[not found] ` <20171130113533.4485d894@gandalf.local.home>
2017-12-01 12:26 ` Null pointer 4.14.1-rt3 Sebastian Andrzej Siewior
2017-12-01 16:03 ` Steven Rostedt
2017-12-01 16:38 ` Sebastian Andrzej Siewior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).