From: Tony Lindgren <tony@atomide.com>
To: Dave Gerlach <d-gerlach@ti.com>
Cc: Santosh Shilimkar <ssantosh@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Keerthy J <j-keerthy@ti.com>, Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH v6 0/2] memory: Introduce ti-emif-sram driver
Date: Fri, 1 Dec 2017 09:54:18 -0800 [thread overview]
Message-ID: <20171201175418.GS28152@atomide.com> (raw)
In-Reply-To: <1512082568-5012-1-git-send-email-d-gerlach@ti.com>
* Dave Gerlach <d-gerlach@ti.com> [171130 22:58]:
> This is a resend of v5 of this series found here [1]. It introduces
> relocatable PM handlers for the emif that are copied to sram and
> run from there during low power mode entry.
>
> The patches still have the previous ACKs but have a small change to
> accomodate a change made by Tony in commit cd57dc5a2099 ("ARM: dts:
> Add missing hwmod related nodes for am33xx"). If there are objections
> to this let me know ASAP.
Still looks good to me thanks.
> Now that a hwmod is present for the am335x EMIF, on probe fail the call to
> pm_runtime_put_sync causes the board to hang. In fact, this emif driver should
> never alter the PM state of the hardware at all through normal kernel calls, it
> is the job of the suspend handlers that are added, that is the whole point of
> this driver. Because of this, I have dropped all runtime pm calls, as any
> change to the PM state while the kernel is running is dangerous as we may shut
> of the memory controller. It makes the most sense just to drop runtime PM from
> the driver entirely. Besides that patch is unchanged.
OK makes sense to me.
Regards,
Tony
next prev parent reply other threads:[~2017-12-01 17:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 22:56 [PATCH v6 0/2] memory: Introduce ti-emif-sram driver Dave Gerlach
2017-11-30 22:56 ` [PATCH v6 1/2] Documentation: dt: Update ti,emif bindings Dave Gerlach
2017-11-30 22:56 ` [PATCH v6 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers Dave Gerlach
2017-12-01 17:54 ` Tony Lindgren [this message]
2017-12-01 21:58 ` [PATCH v6 0/2] memory: Introduce ti-emif-sram driver Santosh Shilimkar
2017-12-03 4:00 ` santosh.shilimkar
2017-12-03 16:36 ` Tony Lindgren
2017-12-04 17:35 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201175418.GS28152@atomide.com \
--to=tony@atomide.com \
--cc=d-gerlach@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=johan@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).