From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752884AbdLDAoe (ORCPT <rfc822;w@1wt.eu>);
        Sun, 3 Dec 2017 19:44:34 -0500
Received: from mail-pg0-f68.google.com ([74.125.83.68]:37054 "EHLO
        mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752079AbdLDAoa (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 3 Dec 2017 19:44:30 -0500
X-Google-Smtp-Source: AGs4zMYx+gN2VQArj8aCPMMfm7hKW6cGf2BEZeSq0rXzTj41ZG2ZW2zPncHJRRiO0uWONeLiEhkmcA==
Date: Sun, 3 Dec 2017 16:44:27 -0800
From: Eric Biggers <ebiggers3@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: syzbot 
        <bot+583353673e394aa41e5fb68ddc8b8d9d5c8d576f@syzkaller.appspotmail.com>,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        mingo@redhat.com, rostedt@goodmis.org, syzkaller-bugs@googlegroups.com
Subject: Re: possible deadlock in blk_trace_remove
Message-ID: <20171204004427.GA13374@zzz.localdomain>
References: <001a1141f8dc4440a9055e53896e@google.com>
 <20171203202434.GD844@zzz.localdomain>
 <9f7ab661-7d57-3e84-769c-6d103557f342@kernel.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9f7ab661-7d57-3e84-769c-6d103557f342@kernel.dk>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Dec 03, 2017 at 05:24:32PM -0700, Jens Axboe wrote:
> On 12/03/2017 01:24 PM, Eric Biggers wrote:
> > On Sun, Nov 19, 2017 at 02:36:01AM -0800, syzbot wrote:
> >> Hello,
> >>
> >> syzkaller hit the following crash on
> >> d9e0e63d9a6f88440eb201e1491fcf730272c706
> >> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master
> >> compiler: gcc (GCC) 7.1.1 20170620
> >> .config is attached
> >> Raw console output is attached.
> >>
> >> Unfortunately, I don't have any reproducer for this bug yet.
> >>
> >>
> >> Use struct sctp_sack_info instead
> >>
> >> ============================================
> >> WARNING: possible recursive locking detected
> >> 4.14.0-rc8-next-20171110+ #40 Not tainted
> >> --------------------------------------------
> >> syz-executor6/21462 is trying to acquire lock:
> >>  (&q->blk_trace_mutex){+.+.}, at: [<ffffffff81760261>]
> >> blk_trace_remove+0x21/0x40 kernel/trace/blktrace.c:373
> >>
> >> but task is already holding lock:
> >>  (&q->blk_trace_mutex){+.+.}, at: [<ffffffff81763b38>]
> >> blk_trace_setup+0x38/0x70 kernel/trace/blktrace.c:606
> >>
> >> other info that might help us debug this:
> >>  Possible unsafe locking scenario:
> > 
> > #syz fix: blktrace: fix trace mutex deadlock
> 
> This is fixed in current -git.
> 

I know, but syzbot needed to be told what commit fixes the bug.
See https://github.com/google/syzkaller/blob/master/docs/syzbot.md