From: Lee Jones <lee.jones@linaro.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: Guenter Roeck <groeck@google.com>,
Thierry Escande <thierry.escande@collabora.com>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] cros_ec: Move cros_ec_dev module to drivers/mfd
Date: Mon, 4 Dec 2017 09:10:26 +0000 [thread overview]
Message-ID: <20171204091026.yo7rbc3hwp3ygae7@dell> (raw)
In-Reply-To: <CAMHSBOVWsKHCW4xuj_k1X1xyQOiF7xSa4MYDEJc6g1V00nbRxQ@mail.gmail.com>
On Fri, 01 Dec 2017, Gwendal Grignou wrote:
> Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Can you please reply inline (where Guenter did is perfect) and snip
the rest please? Top posting is to be strongly discouraged.
> On Thu, Nov 30, 2017 at 12:50 PM, Guenter Roeck <groeck@google.com> wrote:
> > On Mon, Nov 20, 2017 at 8:15 AM, Thierry Escande
> > <thierry.escande@collabora.com> wrote:
> >> The cros_ec_dev module is responsible for registering the MFD devices
> >> attached to the ChromeOS EC. This patch moves this module to drivers/mfd
> >> so calls to mfd_add_devices() are not done from outside the MFD subtree
> >> anymore.
> >>
> >> Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
> >
> > Tested-by: Guenter Roeck <groeck@chromium.org>
> >
> >> ---
> >> drivers/mfd/Kconfig | 10 +
> >> drivers/mfd/Makefile | 1 +
> >> drivers/mfd/cros_ec_dev.c | 552 ++++++++++++++++++++++++++++
> >> drivers/mfd/cros_ec_dev.h | 52 +++
> >> drivers/platform/chrome/Kconfig | 10 -
> >> drivers/platform/chrome/Makefile | 1 -
> >> drivers/platform/chrome/cros_ec_debugfs.c | 3 -
> >> drivers/platform/chrome/cros_ec_debugfs.h | 27 --
> >> drivers/platform/chrome/cros_ec_dev.c | 553 -----------------------------
> >> drivers/platform/chrome/cros_ec_dev.h | 52 ---
> >> drivers/platform/chrome/cros_ec_lightbar.c | 2 -
> >> drivers/platform/chrome/cros_ec_sysfs.c | 2 -
> >> include/linux/mfd/cros_ec.h | 4 +
> >> 13 files changed, 619 insertions(+), 650 deletions(-)
> >> create mode 100644 drivers/mfd/cros_ec_dev.c
> >> create mode 100644 drivers/mfd/cros_ec_dev.h
> >> delete mode 100644 drivers/platform/chrome/cros_ec_debugfs.h
> >> delete mode 100644 drivers/platform/chrome/cros_ec_dev.c
> >> delete mode 100644 drivers/platform/chrome/cros_ec_dev.h
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-12-04 9:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 16:15 [PATCH v2 0/2] mfd: cros_ec: move cros_ec_dev driver to MFD subdir Thierry Escande
2017-11-20 16:15 ` [PATCH v2 1/2] cros_ec: Split cros_ec_devs module Thierry Escande
2017-11-29 11:34 ` Lee Jones
2017-11-30 20:49 ` Guenter Roeck
2017-12-01 19:24 ` Gwendal Grignou
2017-11-20 16:15 ` [PATCH v2 2/2] cros_ec: Move cros_ec_dev module to drivers/mfd Thierry Escande
2017-11-29 11:35 ` Lee Jones
2017-11-30 20:50 ` Guenter Roeck
2017-12-01 19:23 ` Gwendal Grignou
2017-12-04 9:10 ` Lee Jones [this message]
2018-06-20 23:05 ` Dmitry Torokhov
2018-06-21 8:42 ` Enric Balletbo i Serra
2018-07-03 9:03 ` Lee Jones
2017-12-15 10:48 ` [GIT PULL] Immutable branch between MFD and Platform due for the v4.16 merge window Lee Jones
2017-12-16 4:50 ` Benson Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204091026.yo7rbc3hwp3ygae7@dell \
--to=lee.jones@linaro.org \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@google.com \
--cc=gwendal@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.escande@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).