From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753857AbdLDJKa (ORCPT ); Mon, 4 Dec 2017 04:10:30 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:39578 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753571AbdLDJK0 (ORCPT ); Mon, 4 Dec 2017 04:10:26 -0500 Date: Mon, 4 Dec 2017 10:10:32 +0100 From: Greg KH To: Stephen Rothwell Cc: Lee Jones , Linux-Next Mailing List , Linux Kernel Mailing List , Rui Feng , Daniel Bristot de Oliveira , Perry Yuan Subject: Re: linux-next: build failure after merge of the mfd tree Message-ID: <20171204091032.GD16936@kroah.com> References: <20171204141956.5b90bc18@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171204141956.5b90bc18@canb.auug.org.au> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 04, 2017 at 02:19:56PM +1100, Stephen Rothwell wrote: > Hi Lee, > > After merging the mfd tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/staging/rts5208/sd.o: In function `.sd_power_off_card3v3': > (.text+0x5760): multiple definition of `.sd_power_off_card3v3' > drivers/misc/cardreader/rtsx_pcr.o:(.text+0x4630): first defined here > drivers/staging/rts5208/sd.o:(.opd+0x378): multiple definition of `sd_power_off_card3v3' > drivers/misc/cardreader/rtsx_pcr.o:(.opd+0x4f8): first defined here > drivers/staging/rts5208/ms.o: In function `.ms_power_off_card3v3': > (.text+0x5e70): multiple definition of `.ms_power_off_card3v3' > drivers/misc/cardreader/rtsx_pcr.o:(.text+0x46e0): first defined here > drivers/staging/rts5208/ms.o:(.opd+0x360): multiple definition of `ms_power_off_card3v3' > drivers/misc/cardreader/rtsx_pcr.o:(.opd+0x510): first defined here > > > Caused by commit > > 5da4e04ae480 ("misc: rtsx: Add support for RTS5260") > > I added the following fix patch: > > From: Stephen Rothwell > Date: Mon, 4 Dec 2017 14:10:34 +1100 > Subject: [PATCH] misc: rtsx: fix symbol clashes > > Signed-off-by: Stephen Rothwell > --- > drivers/misc/cardreader/rts5260.c | 4 ++-- > drivers/misc/cardreader/rtsx_pcr.c | 4 ++-- > drivers/misc/cardreader/rtsx_pcr.h | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) Acked-by: Greg Kroah-Hartman