From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] drm/i915: Mark expected switch fall-throughs
Date: Mon, 04 Dec 2017 09:20:45 -0600 [thread overview]
Message-ID: <20171204092045.Horde.5M1LmPnqkpe4as2CWf9PPSh@gator4166.hostgator.com> (raw)
In-Reply-To: <1512383705.4394.18.camel@linux.intel.com>
Hi Joonas,
Quoting Joonas Lahtinen <joonas.lahtinen@linux.intel.com>:
> On Mon, 2017-11-27 at 16:17 -0600, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>
> I have to say I'm totally not sold on regexps matching comment
> contents. Was something more explicit ever considered? Like:
>
> #define FALLTHROUGH __attribute__((fallthrough));
>
> With the appropriate version checks, of course.
>
One of the arguments is that comments lets us leverage the existing
static analyzers.
We've been discussing this during the last week, feel free to join the
discussion:
http://www.spinics.net/lists/kernel/msg2659908.html
http://www.spinics.net/lists/kernel/msg2659906.html
Thanks!
--
Gustavo A. R. Silva
next prev parent reply other threads:[~2017-12-04 15:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 22:17 [PATCH] drm/i915: Mark expected switch fall-throughs Gustavo A. R. Silva
2017-12-04 10:35 ` Joonas Lahtinen
2017-12-04 15:20 ` Gustavo A. R. Silva [this message]
2017-12-04 18:11 ` [Intel-gfx] " Daniel Vetter
2018-06-28 22:35 Gustavo A. R. Silva
2018-06-29 8:23 ` Jani Nikula
2018-07-05 13:43 ` Jani Nikula
2018-07-05 13:48 ` Gustavo A. R. Silva
2019-07-22 18:12 Gustavo A. R. Silva
2019-07-22 18:24 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204092045.Horde.5M1LmPnqkpe4as2CWf9PPSh@gator4166.hostgator.com \
--to=garsilva@embeddedor.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).