From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Eric Biggers <ebiggers3@gmail.com>,
syzbot
<bot+2797c18fc195e3e240c3c3e7837a14130e157fb0@syzkaller.appspotmail.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
dave.jiang@intel.com, LKML <linux-kernel@vger.kernel.org>,
syzkaller-bugs@googlegroups.com,
Al Viro <viro@zeniv.linux.org.uk>,
linux-block@vger.kernel.org
Subject: Re: WARNING in kmalloc_slab (3)
Date: Mon, 4 Dec 2017 12:26:32 +0300 [thread overview]
Message-ID: <20171204092632.mh772rjaqahgslvp@mwanda> (raw)
In-Reply-To: <CACT4Y+aE-Q-PeUaY99d2UbK4BHnf18OoV0MBXyOXzXttf1=nYw@mail.gmail.com>
On Mon, Dec 04, 2017 at 09:18:05AM +0100, Dmitry Vyukov wrote:
> On Mon, Dec 4, 2017 at 9:14 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Sun, Dec 03, 2017 at 12:16:08PM -0800, Eric Biggers wrote:
> >> Looks like BLKTRACESETUP doesn't limit the '.buf_nr' parameter, allowing anyone
> >> who can open a block device to cause an extremely large kmalloc. Here's a
> >> simplified reproducer:
> >>
> >
> > There are lots of places which allow people to allocate as much as they
> > want. With Syzcaller, you might want to just hard code a __GFP_NOWARN
> > in to disable it.
>
> Hi,
>
> Hard code it where?
My idea was to just make warn_alloc() a no-op.
>
> User-controllable allocation are supposed to use __GFP_NOWARN.
No that's not right. What we don't want is unprivileged users to use
all the memory and we don't want unprivileged users to spam
/var/log/messages. But you have to have slightly elevated permissions
to open block devices right? The warning is helpful. Admins should
"don't do that" if they don't want the warning.
The kernel really isn't designed to work with Oops on Warn. I try to
tell people simple thinks like not printing a warning when
copy_from_user() fails because I don't want /var/log/messages to get
spammed. But there are lots and lots of places which generate warnings.
regards,
dan carpenter
next prev parent reply other threads:[~2017-12-04 9:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-03 14:25 WARNING in kmalloc_slab (3) syzbot
2017-12-03 20:16 ` Eric Biggers
2017-12-04 8:14 ` Dan Carpenter
2017-12-04 8:18 ` Dmitry Vyukov
2017-12-04 9:26 ` Dan Carpenter [this message]
2017-12-12 15:50 ` Dmitry Vyukov
2017-12-12 21:22 ` Eric Biggers
2018-02-07 4:58 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204092632.mh772rjaqahgslvp@mwanda \
--to=dan.carpenter@oracle.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bot+2797c18fc195e3e240c3c3e7837a14130e157fb0@syzkaller.appspotmail.com \
--cc=dave.jiang@intel.com \
--cc=dvyukov@google.com \
--cc=ebiggers3@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).