From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753605AbdLDOyA (ORCPT ); Mon, 4 Dec 2017 09:54:00 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:55957 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751205AbdLDOx5 (ORCPT ); Mon, 4 Dec 2017 09:53:57 -0500 From: Arnd Bergmann To: Philipp Zabel Cc: Arnd Bergmann , Lucas Stach , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] gpu: ipu-v3: prg: avoid possible array underflow Date: Mon, 4 Dec 2017 15:53:35 +0100 Message-Id: <20171204145347.597518-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:XntVzk4UHgboyykylPMDPh7qmET4dTy5XaodR6Lu7ME0b222Il5 gV6CqdloU0X5Uhc/WSqZc+AALrMX3QMOEy8AXAjhyAez+IJVNjUG/aA8GmLf2f5cA+LYdYj 7SbSe/IEWDiuiVPqExallx6dHOvq7w7lGnkYO/auLaJfhNZ9wl9ydA4eprcaMC0f06hRxnJ GMsdFEXBP3Q+LU9yoD4/g== X-UI-Out-Filterresults: notjunk:1;V01:K0:SBkRoq2UCGk=:t61Tn0EXhJ9EuZ4rUCJFJg XnmxEFilqLzdqI1sYil1qVbM0RWx1+SgHqqUC3csfOuuxzYLkpssbixggA3La+AFNbAp9gn38 nP8fkl0MbnpnV0lfiMIdGnnn+yvCip4qA4nX3kx0IxAoam/GgS+W74d5HpIoeKAaL2TjhZ4Zv mUyzMwR3jeU3Z7Gaxvwd5V/efrNOh/GOs/GS+aTVnQZN7zs3khaqZl/EQxfr0rs6CDfp9NGaO 1yAy1G+BSs132w0rIZ6B/ux/odNLeShnsIMo8paH24K8elmTNIAVuVxd8D/i4Jlg8zoLmcIEM w1TaQjtMMvwH2BhG1Zlf5kPgNyCKPMf4S+vgp3N/ZvLOl5oBwyr89Z/szyviDWr53a4IjMgq8 U62NUT9/Y+G6dWfRIGH4gH/QoWu3MMOprlRwNLp5kZrZjCzx9eB+xb6aXvPlxNP7fZhI5NM9V a8ZwG8izTmtJa+t9t+NwAFWIwuJqaY5BgLJIANqf4ZMOsqYFiiEPULodnDj/yP1eOuPqhYwpl KDBOUrIfL4/36CiqbpD1MSrzxO1/WOz2619npjmqkLScvr+asijjzMRmWitte2nWM5m8Nhyhe 66pLPCN1gQ61WbpxVMGgSvXJYQmlowPYG9UrwnzMaRrYXm1Q+NeWK376RUnVGR2YoXIDECgNv OJBbTHnOBfkh9K7fZqqhPhpzsaEsgVGo1fe8hAXAhcgIxsTg0dGQzBWvow9yQLk2ecVvrC1ss DSbAlbQCE/6UxVgr8EfprpIXMJyMEVxK/SiOqA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc-8 reports that we access an array with a negative index in an error case: drivers/gpu/ipu-v3/ipu-prg.c: In function 'ipu_prg_channel_disable': drivers/gpu/ipu-v3/ipu-prg.c:252:43: error: array subscript -22 is below array bounds of 'struct ipu_prg_channel[3]' [-Werror=array-bounds] This moves the range check in front of the dereference. Signed-off-by: Arnd Bergmann --- drivers/gpu/ipu-v3/ipu-prg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/ipu-v3/ipu-prg.c b/drivers/gpu/ipu-v3/ipu-prg.c index 0013ca9f72c8..1417db856989 100644 --- a/drivers/gpu/ipu-v3/ipu-prg.c +++ b/drivers/gpu/ipu-v3/ipu-prg.c @@ -252,7 +252,7 @@ void ipu_prg_channel_disable(struct ipuv3_channel *ipu_chan) struct ipu_prg_channel *chan = &prg->chan[prg_chan]; u32 val; - if (!chan->enabled || prg_chan < 0) + if (prg_chan < 0 || !chan->enabled) return; clk_prepare_enable(prg->clk_ipg); -- 2.9.0