From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751436AbdLDPfT (ORCPT ); Mon, 4 Dec 2017 10:35:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:34066 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750786AbdLDPfS (ORCPT ); Mon, 4 Dec 2017 10:35:18 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 959B220C51 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Mon, 4 Dec 2017 12:35:14 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Namhyung Kim , Jiri Olsa , lkml , Ingo Molnar , David Ahern , Peter Zijlstra , kernel-team@lge.com Subject: Re: [PATCH 2/3] perf tools: Fix build for hardened environments Message-ID: <20171204153514.GB13698@kernel.org> References: <20171108102739.30338-1-jolsa@kernel.org> <20171108102739.30338-3-jolsa@kernel.org> <20171201021137.GA30867@sejong> <20171204073431.GB30564@krava> <20171204082437.GC30564@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171204082437.GC30564@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Dec 04, 2017 at 09:24:37AM +0100, Jiri Olsa escreveu: > On Mon, Dec 04, 2017 at 08:34:31AM +0100, Jiri Olsa wrote: > > On Fri, Dec 01, 2017 at 11:11:37AM +0900, Namhyung Kim wrote: > > > Hi Jiri, > > > > > > On Wed, Nov 08, 2017 at 11:27:38AM +0100, Jiri Olsa wrote: > > > > From: Jiri Olsa > > > > > > > > On Fedora systems the perl and python CFLAGS/LDFLAGS include the > > > > hardened specs from redhat-rpm-config package. We apply them only > > > > for perl/python objects, which makes them not compatible with the > > > > rest of the objects and the build fails with: > > > > > > > > /usr/bin/ld: perf-in.o: relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC > > > > /usr/bin/ld: libperf.a(libperf-in.o): relocation R_X86_64_32S against `.text' can not be used when making a shared object; recompile with -fPIC > > > > /usr/bin/ld: final link failed: Nonrepresentable section on output > > > > collect2: error: ld returned 1 exit status > > > > make[2]: *** [Makefile.perf:507: perf] Error 1 > > > > make[1]: *** [Makefile.perf:210: sub-make] Error 2 > > > > make: *** [Makefile:69: all] Error 2 > > > > > > > > Mainly it's caused by perl/python objects being compiled with: > > > > > > > > -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 > > > > > > > > which prevent the final link impossible, because it will check > > > > for 'proper' objects with following option: > > > > > > > > -specs=/usr/lib/rpm/redhat/redhat-hardened-ld > > > > > > Just for curiousity, could you please show me the contents of the two > > > files? (Are they big?) > > > > # cat /usr/lib/rpm/redhat/redhat-hardened-ld > > *self_spec: > > + %{!static:%{!shared:%{!r:-pie}}} > > > > *link: > > + -z now > > > > > > # cat /usr/lib/rpm/redhat/redhat-hardened-cc1 > > *cc1_options: > > + %{!r:%{!fpie:%{!fPIE:%{!fpic:%{!fPIC:%{!fno-pic:-fPIE}}}}}} > > > looks like we could remove that spec totaly and get things working > we already do that for CC_NO_CLANG > > could you guys test patch below? works on my setup Works for me as well, builds in f27 with gcc and with clang, I've added it to my perf/core branch with the original commig message modulo the description of the original fix. If you want to have a different message, feel free to send it to me and I'll make the adjustments if this takes place before my next pull req to Ingo :-) Thanks, - Arnaldo