From: "J. Bruce Fields" <bfields@fieldses.org>
To: Thiago Rafael Becker <thiago.becker@gmail.com>
Cc: NeilBrown <neilb@suse.com>,
linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3, V2] kernel: Move groups_sort to the caller of set_groups.
Date: Mon, 4 Dec 2017 10:47:15 -0500 [thread overview]
Message-ID: <20171204154715.GB4405@fieldses.org> (raw)
In-Reply-To: <alpine.LFD.2.21.1712041049280.1738@tbecker-rhat>
On Mon, Dec 04, 2017 at 01:39:37PM -0200, Thiago Rafael Becker wrote:
>
>
> On Mon, 4 Dec 2017, NeilBrown wrote:
>
> >I think you need to add groups_sort() in a few more places.
> >Almost anywhere that calls groups_alloc() should be considered.
> >net/sunrpc/svcauth_unix.c, net/sunrpc/auth_gss/svcauth_gss.c,
> >fs/nfsd/auth.c definitely need it.
>
> So are any other functions that modify group_info. OK, I think I'll
> implement the type detection below as it helps detecting where these
> situations are located.
>
> This may take some time to make sane. I wonder if we shouldn't
> accept the first change suggested to fix the corruption detected in
> auth.unix.gid while I work on a new set of patches. Also, that patch
> doesn't change behavior of set_groups, and is easier to backport if
> distros relying on older kernels need to do so and change behavior.
> The first suggestion is undergoing tests, and so far we didn't
> detect any new corruptions on auth.unix.gid.
I'm a little confused--we can remedy the oversight Neil points out just
by adding a few more group_sort()s, and that shouldn't be hard, right?
I'd be OK with doing that first and then adding a code to enforce the
sorting second.
--b.
>
> >Maybe it could be done with types.
>
> I changed the interfaces on groups_{alloc,sort} to check. There are
> some extra changes needed in groups_from_user and others to make
> this viable, but I like it and I'll try to make it happen.
>
> >Thanks,
> >NeilBrown
> >
>
> Thanks,
> trbecker
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-04 15:47 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 13:04 [PATCH 0/3, V2] Move groups_sort outisde of set_groups Thiago Rafael Becker
2017-11-30 13:04 ` [PATCH 1/3, V2] kernel: make groups_sort globally visible Thiago Rafael Becker
2017-11-30 13:04 ` [PATCH 2/3, V2] kernel: Move groups_sort to the caller of set_groups Thiago Rafael Becker
2017-12-03 12:56 ` kbuild test robot
2017-12-04 1:42 ` NeilBrown
2017-12-04 15:39 ` Thiago Rafael Becker
2017-12-04 15:47 ` J. Bruce Fields [this message]
2017-12-04 19:00 ` Thiago Rafael Becker
2017-12-04 20:11 ` NeilBrown
2017-12-05 21:28 ` Matthew Wilcox
2017-12-05 22:05 ` NeilBrown
2017-12-05 23:03 ` Thiago Rafael Becker
2017-12-05 23:23 ` Matthew Wilcox
2017-12-19 16:30 ` J. Bruce Fields
2017-12-19 20:14 ` NeilBrown
2017-11-30 13:04 ` [PATCH 3/3, V2] kernel: set_groups doesn't call groups_sort anymore Thiago Rafael Becker
2017-12-05 14:05 ` [PATCH 0/3 v3] Move groups_sort outisde of set_groups Thiago Rafael Becker
2017-12-05 14:05 ` [PATCH 1/3 v3] kernel: make groups_sort globally visible Thiago Rafael Becker
2017-12-05 14:05 ` [PATCH 2/3 v3] kernel: Move groups_sort to the caller of set_groups Thiago Rafael Becker
2017-12-05 18:55 ` [PATCH 2/3] " Thiago Rafael Becker
2017-12-05 22:08 ` NeilBrown
2017-12-05 18:57 ` [PATCH 2/3 v3] " Thiago Rafael Becker
2017-12-05 14:05 ` [PATCH 3/3 v3] kernel: set_groups doesn't call groups_sort anymore Thiago Rafael Becker
2017-12-06 19:27 ` [PATCH 0/3 v3] Move groups_sort outisde of set_groups J. Bruce Fields
2017-12-11 13:28 ` [PATCH v4] kernel: make groups_sort calling a responsibility group_info allocators Thiago Rafael Becker
2017-12-11 14:27 ` Matthew Wilcox
2017-12-11 15:14 ` [PATCH v5] " Thiago Rafael Becker
2017-12-11 15:24 ` Matthew Wilcox
2017-12-11 16:18 ` J. Bruce Fields
2017-12-11 21:43 ` NeilBrown
2018-01-02 14:54 ` David Howells
2018-01-02 21:01 ` [PATCH] Documentation: security/credentials.rst: explain need to sort group_list NeilBrown
2018-01-02 21:04 ` Matthew Wilcox
2018-01-06 18:09 ` Jonathan Corbet
2018-01-06 20:20 ` Matthew Wilcox
2018-01-06 22:36 ` Randy Dunlap
2018-01-08 16:36 ` Jonathan Corbet
2018-01-07 23:39 ` NeilBrown
2018-01-08 16:40 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204154715.GB4405@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.com \
--cc=thiago.becker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).