From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752916AbdLDTWb (ORCPT ); Mon, 4 Dec 2017 14:22:31 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:32913 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751598AbdLDTW1 (ORCPT ); Mon, 4 Dec 2017 14:22:27 -0500 X-Google-Smtp-Source: AGs4zMZ9qMpwt5zGVPW56xPLSqaFDBlqWrJuLLhFW/upl7yncj7CQ+0HW2ICq3YwAyDVxCbDl9kuEw== Date: Mon, 4 Dec 2017 11:20:13 -0800 From: Moritz Fischer To: Moritz Fischer Cc: Alan Tull , Rob Herring , Frank Rowand , Pantelis Antoniou , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org Subject: Re: [PATCH 0/2] of: dynamic: restrict overlay by targets Message-ID: <20171204192013.GB17574@tyrael.ni.corp.natinst.com> References: <20171204191357.3211-1-atull@kernel.org> <20171204191849.GA17574@tyrael.ni.corp.natinst.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171204191849.GA17574@tyrael.ni.corp.natinst.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 04, 2017 at 11:18:49AM -0800, Moritz Fischer wrote: > On Mon, Dec 04, 2017 at 01:13:55PM -0600, Alan Tull wrote: > > Restrict which nodes are valid targets for a DT overlay. > > > > Add a flag bit to struct device_node allowing nodes to be marked as > > valid target for overlays. > > > > A driver that is always intended to handle DT overlays can > > enable overlays by calling a function for its DT node. > > > > For individual nodes that need to be opened up for a specific use, > > adding the property "overlay-allowed" enables overlays targeting > > that node. I'll need to document the DT property, not sure where > > specifically. New file bindings/overlay.txt? > > > > This patchset differs from the RFC: > > * Added a flag bit and got rid of the whitelist > > * Renamed the functions that enable a node > > * Added a DT property > > > > Alan Tull (2): > > of: overlay: add flag enabling overlays and enable fpga-region > > overlays > > of: dynamic: add overlay-allowed DT property > > I think [1/2] and [2/2] are backwards order. If applied like this, > it won't work. [1/2] uses stuff that gets added in [2/2] Ignore that, my mailclient is being funny. Moritz > > > > > drivers/fpga/of-fpga-region.c | 4 ++++ > > drivers/of/base.c | 4 ++-- > > drivers/of/dynamic.c | 3 +++ > > drivers/of/fdt.c | 3 +++ > > drivers/of/of_private.h | 2 ++ > > drivers/of/overlay.c | 26 ++++++++++++++++++++++++++ > > include/linux/of.h | 19 +++++++++++++++++++ > > 7 files changed, 59 insertions(+), 2 deletions(-) > > > > -- > > 2.7.4 > > > > Moritz