From: David Miller <davem@davemloft.net>
To: salil.mehta@huawei.com
Cc: yisen.zhuang@huawei.com, lipeng321@huawei.com,
mehta.salil.lnk@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
linuxarm@huawei.com
Subject: Re: [PATCH V2 net-next 0/3] net: hns3: Refactors "reset" handling code in HCLGE layer of HNS3 driver
Date: Tue, 05 Dec 2017 11:48:33 -0500 (EST) [thread overview]
Message-ID: <20171205.114833.2112478522356368321.davem@davemloft.net> (raw)
In-Reply-To: <20171204012955.17560-1-salil.mehta@huawei.com>
From: Salil Mehta <salil.mehta@huawei.com>
Date: Mon, 4 Dec 2017 01:29:52 +0000
> This patch refactors the code of the reset feature in HCLGE layer
> of HNS3 PF driver. Prime motivation to do this change is:
> 1. To reduce the time for which common miscellaneous Vector 0
> interrupt is disabled because of the reset. Simplification
> of the common miscellaneous interrupt handler routine(for
> Vector 0) used to handle reset and other sources of Vector
> 0 interrupt.
> 2. Separate the task for handling the reset
> 3. Simplification of reset request submission and pending reset
> logic.
>
>
> To achieve above below few things have been done:
> 1. Interrupt is disabled while common miscellaneous interrupt
> handler is entered and re-enabled before it is exit. This
> reduces the interrupt handling latency as compared to older
> interrupt handling scheme where interrupt was being disabled
> in interrupt handler context and re-enabled in task context
> some time later. Made Miscellaneous interrupt handler more
> generic to handle all sources including reset interrupt source.
> 2. New reset service task has been introduced to service the
> reset handling.
> 3. Introduces new reset service task for honoring software reset
> requests like from network stack related to timeout and serving
> the pending reset request(to reset the driver and associated
> clients).
>
>
> Change Log:
> Patch V2: Addressed comment by Andrew Lunn
> Link: https://lkml.org/lkml/2017/12/1/366
> Patch V1: Initial Submit
Series applied, thank you.
next prev parent reply other threads:[~2017-12-05 16:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 1:29 [PATCH V2 net-next 0/3] net: hns3: Refactors "reset" handling code in HCLGE layer of HNS3 driver Salil Mehta
2017-12-04 1:29 ` [PATCH V2 net-next 1/3] net: hns3: Refactor of the reset interrupt handling logic Salil Mehta
2017-12-04 1:29 ` [PATCH V2 net-next 2/3] net: hns3: Add reset service task for handling reset requests Salil Mehta
2017-12-04 1:29 ` [PATCH V2 net-next 3/3] net: hns3: Refactors the requested reset & pending reset handling code Salil Mehta
2017-12-05 16:48 ` David Miller [this message]
2017-12-05 16:59 ` [PATCH V2 net-next 0/3] net: hns3: Refactors "reset" handling code in HCLGE layer of HNS3 driver Salil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205.114833.2112478522356368321.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=mehta.salil.lnk@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).