From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Fengguang Wu <fengguang.wu@intel.com>,
linux-kernel@vger.kernel.org, Wang Nan <wangnan0@huawei.com>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Will Deacon <will.deacon@arm.com>,
lkp@01.org, Dmitry Vyukov <dvyukov@google.com>,
kasan-dev@googlegroups.com, kernel-team@lge.com
Subject: Re: BUG: KASAN: slab-out-of-bounds in perf_callchain_user+0x494/0x530
Date: Tue, 5 Dec 2017 17:11:56 +0900 [thread overview]
Message-ID: <20171205081156.GB16663@sejong> (raw)
In-Reply-To: <20171130193712.GU3298@kernel.org>
Hello,
On Thu, Nov 30, 2017 at 04:37:12PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Nov 30, 2017 at 09:20:26AM +0100, Peter Zijlstra escreveu:
> > On Thu, Nov 30, 2017 at 10:32:19AM +0800, Fengguang Wu wrote:
> > > Hello,
> > >
> > > FYI this happens in mainline kernel 4.15.0-rc1.
> > > It looks like a new regression and hard to bisect.
> > >
> > > It occurs in 1 out of 57 boots.
> > >
> > > [ 10.009610] chown (367) used greatest stack depth: 26944 bytes left
> > > Kernel tests: Boot OK!
> > > [ 30.357729] trinity-main uses obsolete (PF_INET,SOCK_PACKET)
> > > [ 31.301433] sock: process `trinity-main' is using obsolete setsockopt SO_BSDCOMPAT
> > > [ 31.310289] ==================================================================
> > > [ 31.311490] BUG: KASAN: slab-out-of-bounds in perf_callchain_user+0x494/0x530:
> > > perf_callchain_store at include/linux/perf_event.h:1128
> > > (inlined by) perf_callchain_user at arch/x86/events/core.c:2485
> >
> > I don't think we recently changed anything here...
> >
> > But I do have vague memories of something being off here; I never quite
> > could penetrate the max_stack / contexts_maxed stuff, and istr acme was
> > going to have a peek.
>
> Sure, but I saw some backward ring buffer stuff in there as well, no?
> IIRC that came after the max-stack code, Adding Wang to the CC list.
I think it's because of per-event max-stack not being checked for the
first event. Please see the patch below..
Also I'm not sure that the allocation failure check would work
correctly since it decrements nr_callchain_events when it fails.
Thanks,
Namhyung
>From c12126c4ff9835f0899619db3ee7b4a3151ff2bb Mon Sep 17 00:00:00 2001
From: Namhyung Kim <namhyung@kernel.org>
Date: Tue, 5 Dec 2017 16:54:50 +0900
Subject: [PATCH] perf/core: Fix overflow on perf_callchain_entry
The commit 97c79a38cd45 add a check whether per-event max stack is
greater than the global max. But it missed to do it for the first
event. So if the event had a stack depth greater than the global max,
it could overflow the callchain entry list.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Fixes: 97c79a38cd45 ("perf core: Per event callchain limit")
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
kernel/events/callchain.c | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/kernel/events/callchain.c b/kernel/events/callchain.c
index 1b2be63c8528..e449e23802eb 100644
--- a/kernel/events/callchain.c
+++ b/kernel/events/callchain.c
@@ -119,19 +119,22 @@ int get_callchain_buffers(int event_max_stack)
goto exit;
}
+ /*
+ * If requesting per event more than the global cap,
+ * return a different error to help userspace figure this out.
+ *
+ * And also do it here so that we have &callchain_mutex held.
+ */
+ if (event_max_stack > sysctl_perf_event_max_stack) {
+ err = -EOVERFLOW;
+ goto exit;
+ }
+
if (count > 1) {
/* If the allocation failed, give up */
if (!callchain_cpus_entries)
err = -ENOMEM;
- /*
- * If requesting per event more than the global cap,
- * return a different error to help userspace figure
- * this out.
- *
- * And also do it here so that we have &callchain_mutex held.
- */
- if (event_max_stack > sysctl_perf_event_max_stack)
- err = -EOVERFLOW;
+
goto exit;
}
--
2.15.0
next prev parent reply other threads:[~2017-12-05 8:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 2:32 BUG: KASAN: slab-out-of-bounds in perf_callchain_user+0x494/0x530 Fengguang Wu
2017-11-30 8:20 ` Peter Zijlstra
2017-11-30 19:37 ` Arnaldo Carvalho de Melo
2017-12-05 8:11 ` Namhyung Kim [this message]
2017-12-05 13:37 ` Arnaldo Carvalho de Melo
2017-12-05 14:47 ` Namhyung Kim
2017-12-06 13:47 ` Peter Zijlstra
2017-12-06 14:12 ` Arnaldo Carvalho de Melo
2017-12-06 14:31 ` Namhyung Kim
2017-12-06 15:45 ` Peter Zijlstra
2017-12-06 15:49 ` Namhyung Kim
2017-12-06 16:39 ` Peter Zijlstra
2017-12-06 15:46 ` Namhyung Kim
2017-12-06 13:40 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205081156.GB16663@sejong \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=dvyukov@google.com \
--cc=fengguang.wu@intel.com \
--cc=jolsa@redhat.com \
--cc=kasan-dev@googlegroups.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=wangnan0@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).