From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753202AbdLEJkE (ORCPT ); Tue, 5 Dec 2017 04:40:04 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:46550 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753169AbdLEJj6 (ORCPT ); Tue, 5 Dec 2017 04:39:58 -0500 Date: Tue, 5 Dec 2017 10:39:45 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: Quentin Schulz , Linus Walleij , Rob Herring , Mark Rutland , Russell King , Lee Jones , "linux-gpio@vger.kernel.org" , devicetree , linux-kernel , linux-arm-kernel , Thomas Petazzoni , linux-sunxi Subject: Re: [linux-sunxi] [PATCH v4 09/10] ARM: dtsi: axp81x: add GPIO DT node Message-ID: <20171205093945.5sudt23fag7q3ric@flea.lan> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bjgfhlvxfqyubaaf" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --bjgfhlvxfqyubaaf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Dec 05, 2017 at 05:24:47PM +0800, Chen-Yu Tsai wrote: > On Fri, Dec 1, 2017 at 9:44 PM, Quentin Schulz > wrote: > > This adds DT node for the GPIO/pinctrl part present in AXP813/AXP818. > > > > Signed-off-by: Quentin Schulz > > --- > > arch/arm/boot/dts/axp81x.dtsi | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.d= tsi > > index 73b761f..0ef959d 100644 > > --- a/arch/arm/boot/dts/axp81x.dtsi > > +++ b/arch/arm/boot/dts/axp81x.dtsi > > @@ -48,6 +48,12 @@ > > interrupt-controller; > > #interrupt-cells =3D <1>; > > > > + axp_gpio: axp-gpio { > > + compatible =3D "x-powers,axp813-gpio"; > > + gpio-controller; > > + #gpio-cells =3D <2>; >=20 > What about interrupt-controller for directly referenced interrupts from > the GPIO pins? There's a bit more to it to enable interrupts. You would probably need to set up a chained interrupt controller in the GPIO driver, and in the DTS with a interrupt-parent and interrupts properties pointing to the AXP device itself. > Otherwise, >=20 > Acked-by: Chen-Yu Tsai Applied 9 and 10, thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --bjgfhlvxfqyubaaf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlomaV4ACgkQ0rTAlCFN r3Ts7xAAiXYoVBFUhlwAl9G3bX/hUOFgO+OHHKYZA9atvQw4jIfdz1Axk8nCaJCE 1ekT1biWXOAuBDsaQDP4nhUhxZeaS5WSrINaeMg2OJQ1+fSGnMq5DbW8wUjugJAQ p1jgNkcPqCVWxxZ55UpsCMFd+oxg8XFqbIAlFcx3R31prv73VRxoKicZ0hXPVkgI C+Y9N+6LY6PRI2IDUc+ev4mcQv72YjPYG/w5u5Z2iZcVxdxXdTI65uOo4jTK0gR1 vCk89u5erOS6TVLOd49bElx4dKlZo2Opty+6w8EgZPp8lyUuG+yNcy6yOzjLXC5m VXUAlsEe/xCLo3BYuMBB/yZjx5wOeQa3YknEq2caRFm4DgmH3Wcuc2pKNi8xAqcw STvZeJwXTgHfg5P/0kJ1Iih4ZsjAKp3uVi+RVjeFFBxSGl5m0SkXZJDD51CfFZRr cFIi6dqX2kOEmon3nOCwrmeYz50IKjlkRLUyBZbdV7aqGzwo2/8n3mq1XI3U8/xt LQNlQPqMs8qqIZkQpINiSLvSPnfEse4D8UQS0HI7d9jZ8VSVQbIrt9TOd15ON40j W4ptdRoGheTOnCXKAD/s2Y8klA0fzChTJHo3kcadg/HMMRiUBN3AqWNFGrjH10rc TJzQZpc9WNyiHdayEJlVajiK4NAIidAhFB3oQIn7hiov1F4ioqk= =j0Bm -----END PGP SIGNATURE----- --bjgfhlvxfqyubaaf--