From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754718AbdLFEU1 (ORCPT ); Tue, 5 Dec 2017 23:20:27 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:37469 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754625AbdLFET3 (ORCPT ); Tue, 5 Dec 2017 23:19:29 -0500 X-Google-Smtp-Source: AGs4zMbFFNZQWT+bIbbxF2lTA0Dy/rI7o944FiHWuVDXLvn89WZJ+8gHFVqSxmfaacK60nPApOPpUQ== Date: Wed, 6 Dec 2017 07:19:24 +0300 From: Alexey Dobriyan To: sergey.senozhatsky.work@gmail.com Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, me@tobin.cc Subject: Re: [PATCH V11 4/5] vsprintf: add printk specifier %px Message-ID: <20171206041924.GA2959@avx2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > more %p grepping [filtering out all `%ps %pf %pb' variants] gives > a huge number of print outs that potentially can be broken now Because people who introduce this stupid %p hashing can't be bothered to actually audit users: static int show_timer(struct seq_file *m, void *v) { ... seq_printf(m, "signal: %d/%p\n", timer->sigq->info.si_signo, timer->sigq->info.si_value.sival_ptr); Overall, this %px thing doesn't matter. Developers will quickly learn than %p gives some useless irreversible values and start using %px everywhere. Soon someone will use %px in the wrong place and new non-standard format specifier will be added.