From: Christoph Hellwig <hch@lst.de>
To: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Jason Baron <jbaron@akamai.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: waitqueue lockdep annotation
Date: Wed, 6 Dec 2017 15:52:28 -0800 [thread overview]
Message-ID: <20171206235230.19425-1-hch@lst.de> (raw)
Hi all,
this series adds a strategic lockdep_assert_held to __wake_up_common
to ensure callers really do hold the wait_queue_head lock when calling
the unlocked wake_up variants. It turns out epoll did not do this
for a fairly common path (hit all the time by systemd during bootup),
so the second patch fixed this instance as well.
next reply other threads:[~2017-12-06 23:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 23:52 Christoph Hellwig [this message]
2017-12-06 23:52 ` [PATCH 1/2] epoll: use the waitqueue lock to protect ep->wq Christoph Hellwig
2017-12-07 0:49 ` Ingo Molnar
2017-12-07 2:38 ` Andreas Dilger
2017-12-07 6:12 ` Ingo Molnar
2017-12-14 13:06 ` Christoph Hellwig
2017-12-07 16:09 ` Jason Baron
2017-12-14 13:05 ` Christoph Hellwig
2017-12-06 23:52 ` [PATCH 2/2] sched/wait: assert the wait_queue_head lock is held in __wake_up_common Christoph Hellwig
2017-12-07 0:50 ` Ingo Molnar
2017-12-14 13:08 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2017-11-30 14:20 waitqueue lockdep annotation Christoph Hellwig
2017-11-30 20:50 ` Andrew Morton
2017-11-30 21:38 ` Jason Baron
2017-11-30 22:11 ` Christoph Hellwig
2017-11-30 22:18 ` Jason Baron
2017-12-01 17:11 ` Christoph Hellwig
2017-12-01 19:00 ` Jason Baron
2017-12-01 22:02 ` Christoph Hellwig
2017-12-01 22:34 ` Jason Baron
2017-12-01 23:03 ` Christoph Hellwig
2017-12-05 15:24 ` Jason Baron
2017-12-05 15:36 ` Davidlohr Bueso
2017-12-06 23:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171206235230.19425-1-hch@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=jbaron@akamai.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).