From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751741AbdLGId1 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 7 Dec 2017 03:33:27 -0500
Received: from mx2.suse.de ([195.135.220.15]:34917 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750779AbdLGId0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 7 Dec 2017 03:33:26 -0500
Date: Thu, 7 Dec 2017 09:33:15 +0100
From: Borislav Petkov <bp@suse.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andy Lutomirsky <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Greg KH <gregkh@linuxfoundation.org>, keescook@google.com,
        hughd@google.com, Brian Gerst <brgerst@gmail.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Denys Vlasenko <dvlasenk@redhat.com>, Rik van Riel <riel@redhat.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>,
        David Laight <David.Laight@aculab.com>,
        Eduardo Valentin <eduval@amazon.com>, aliguori@amazon.com,
        Will Deacon <will.deacon@arm.com>, daniel.gruss@iaik.tugraz.at,
        Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [patch 31/60] x86/mm/kpti: Add mapping helper functions
Message-ID: <20171207083315.ccvdhywyd45gkz7t@pd.tnic>
References: <20171204140706.296109558@linutronix.de>
 <20171204150607.391576490@linutronix.de>
 <20171205160134.dhrc5oata2hqln3a@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20171205160134.dhrc5oata2hqln3a@pd.tnic>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 05, 2017 at 05:01:34PM +0100, Borislav Petkov wrote:
> > +/*
> > + * Take a PGD location (pgdp) and a pgd value that needs to be set there.
> > + * Populates the user and returns the resulting PGD that must be set in
> > + * the kernel copy of the page tables.
> > + */
> > +static inline pgd_t kpti_set_user_pgd(pgd_t *pgdp, pgd_t pgd)
> > +{
> 
> Btw, do we want to inline a relatively big function like that? I see at
> least 20-ish callsites of set_pgd() only.

Yap, looking at Hugh's version, he has moved it to kaiser.c. I guess in
our case, that should be arch/x86/mm/kpti.c respectively.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--