linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Pravin Shedge <pravin.shedge4linux@gmail.com>
Cc: linux-media@vger.kernel.org, mchehab@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/45] drivers: media: remove duplicate includes
Date: Thu, 7 Dec 2017 15:35:22 +0200	[thread overview]
Message-ID: <20171207133522.yqgb532ftcgvw62d@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <1512579122-5215-1-git-send-email-pravin.shedge4linux@gmail.com>

Hi Pravin,

On Wed, Dec 06, 2017 at 10:22:02PM +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
> 
> Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>

While at it, how about ordering the headers alphabetically as well? Having
such a large number of headers there unordered may well be the reason why
they're included more than once...

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi

  reply	other threads:[~2017-12-07 13:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06 16:52 [PATCH 09/45] drivers: media: remove duplicate includes Pravin Shedge
2017-12-07 13:35 ` Sakari Ailus [this message]
2017-12-10 17:33   ` Pravin Shedge
2017-12-19 10:57     ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171207133522.yqgb532ftcgvw62d@valkosipuli.retiisi.org.uk \
    --to=sakari.ailus@iki.fi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pravin.shedge4linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).