From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752346AbdLGVzc (ORCPT <rfc822;w@1wt.eu>);
        Thu, 7 Dec 2017 16:55:32 -0500
Received: from mail-qt0-f194.google.com ([209.85.216.194]:34524 "EHLO
        mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751625AbdLGVza (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 7 Dec 2017 16:55:30 -0500
X-Google-Smtp-Source: AGs4zMZz8BLeJRqEyLtFQZSgB5/UVc1hF2MyvkmJdC9gQIs0WFw6rXidHuofZuq6i9KVP13nSAaW7A==
Date: Thu, 7 Dec 2017 13:55:25 -0800
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Roman Gushchin <guro@fb.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kernel-team@fb.com>, <ast@kernel.org>, <daniel@iogearbox.net>,
        <kafai@fb.com>, Quentin Monnet <quentin.monnet@netronome.com>,
        David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH v2 net-next 3/4] bpftool: implement prog load command
Message-ID: <20171207135525.4ce09b48@cakuba.netronome.com>
In-Reply-To: <20171207183909.16240-4-guro@fb.com>
References: <20171207183909.16240-1-guro@fb.com>
        <20171207183909.16240-4-guro@fb.com>
Organization: Netronome Systems, Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 7 Dec 2017 18:39:08 +0000, Roman Gushchin wrote:
> Add the prog load command to load a bpf program from a specified
> binary file and pin it to bpffs.
> 
> Usage description and examples are given in the corresponding man
> page.
> 
> Syntax:
> $ bpftool prog load SOURCE_FILE FILE
> 
> FILE is a non-existing file on bpffs.
> 
> Signed-off-by: Roman Gushchin <guro@fb.com>

Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>

The only reservation I have is that SRC may confuse people, would it
make sense to call the compiled code OBJ?  I'm afraid someone may try
to load a C source...