From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754272AbdLGOpW (ORCPT ); Thu, 7 Dec 2017 09:45:22 -0500 Received: from www.llwyncelyn.cymru ([82.70.14.225]:56704 "EHLO fuzix.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754231AbdLGOpT (ORCPT ); Thu, 7 Dec 2017 09:45:19 -0500 Date: Thu, 7 Dec 2017 14:45:09 +0000 From: Alan Cox To: Denys Zagorui Cc: gregkh@linuxfoundation.org, jslaby@suse.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] serial: 8250: convert to threaded IRQ Message-ID: <20171207144509.482b3e45@alans-desktop> In-Reply-To: <20171204152627.23906-1-dzagorui@cisco.com> References: <20171204152627.23906-1-dzagorui@cisco.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 4 Dec 2017 17:26:27 +0200 Denys Zagorui wrote: > During using virtualization it is common to see > many "too much work for irq*" messages. Your emulator is buggy. NAK You are adding a ton of overhead to an absolutely performance critical path on real hardware. We absolutely cannot have 16450 or 16550A UARTS being serviced via a threaded IRQ. Fix your emulator. You are getting the problem because your serial port emulation isn't doing timing correct queueing of characters. If you are modelling 115,200 baud then don't queue characters faster than that or batch them excessively. We went to 512 as the pass limit to allow virtualization layers to get this right more easily as you don't have to do timing on tiny batches. (And if you need performance of any kind stop using the uart emulation and use virtio) Alan