From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752688AbdLGSkB (ORCPT ); Thu, 7 Dec 2017 13:40:01 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:33038 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752629AbdLGSj6 (ORCPT ); Thu, 7 Dec 2017 13:39:58 -0500 From: Roman Gushchin To: CC: , , , , , , , Quentin Monnet , David Ahern Subject: [PATCH v2 net-next 0/4] bpftool: cgroup bpf operations Date: Thu, 7 Dec 2017 18:39:05 +0000 Message-ID: <20171207183909.16240-1-guro@fb.com> X-Mailer: git-send-email 2.14.3 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [2620:10d:c092:200::1:e273] X-ClientProxiedBy: AM0PR0202CA0031.eurprd02.prod.outlook.com (2603:10a6:208:1::44) To CO1PR15MB1079.namprd15.prod.outlook.com (2a01:111:e400:7b66::9) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bebbb3e9-3a7c-475e-53c1-08d53da1dcee X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603286);SRVR:CO1PR15MB1079; X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1079;3:zjVGlg35/lKGAMOvDTFMGMck1TMBDaAzj041B4PKuYjWi2jJKUTx9D09mJ3762pnVjA+cce8YetyD89hplz9U0SkjoKByzcdIdCALsCvyLJl7e/DC3x0bSJ+trc8Zx0Ef0bAm3HdY1D70uQLRgh2ube0wuQnxNIYtXuwBJ+jfXRYB70+KDinAnSqFbbiTc6qWPJpTS/CPAWdR4dJ2N3jtUmVFci+lDrvqk+50Pd/V1cv1dtVcbRj7KlWnpQD7+fy;25:6zZDsTFpnl86fuI11fZR8m08X133EcB8NWxszgKpVriexczTe6cyLGMzDXanMMBnn9pOvFTbs372rdGqVEFZAHgNdLI9u8ASTq0MSQFceWy+e0xyQAuxkC0Vxv0ucJlRzt2UBgK0Cl/Hpl86le8uoSOz9VtjVekwbhD8YCMlTl8UK+4j+NDMa3nlygfy6bT4+LOKcENYbMIhuAcT3A/2G01IDHlStjGg/oQNogUlDnZcZcoCIg/bfulQKKLdQcRcF6/QrGRNSdLk919kXL9LFdASIJDI0a91WBftPobN5+VnMA6L98VpKi7KB+beaITjSAf4xlus7xuEH/FmOOZTtw==;31:CYML31YR7vvlC+THkCalGzpaN0ytit5FVoleiSR59tuNflttHLGzHbiH5wHeyxcRBoarPeq/QRvD/dC8vxDKfBolPbWzHcLoT8zQ7sXbpCXrR5HsBDkibF/jVj2PuH18/BHQuWgMP0et343b4uSKIAZuRGIz3jGvzrul7yxJ61rHsAk9ysRj1UC3StPlIwen/6HeJ4zmQd9PdmqUBTr8JDxUO0GbImWSATBwRRI/xl4= X-MS-TrafficTypeDiagnostic: CO1PR15MB1079: X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1079;20:CMiib16ClcVD7KQhs2e1QnECw1Qov+QerwEMh7DKaffOIW/d1AjkU/9hKtly3VryIea5zIgaWlV7n4xjNIua4PDd6g5RszK8KRCLz1BBMZ3pIG9pqI9wwV1UF7J35FH1DFRxNguThNQxQYHQgXA+BwgJl0VcwWvQ3NKPWKGYkpl0jjGPQ8A3cS60j1ZqDYv6rwJAcWJBBjo4HwMIzUDa+acF5HWbirr0bwCBqzqJiIFwWqkY/JGVK9zOBQCTAm24ZFlO90Jf9XqPSNjp4w2shmKgJ2sDiPdb6zf7VwEkdzMiVx8WwAJkwouLrEOpmozgj+ns8BH/53xtan2PwAjT3PtDS0WzGvRiZwyXwR2gp8tqkM6OE1FHGoNoA0htr6kF34FShallvU4hMq9xnp0X01eID/iCxv7qJlg6j9YCzIOPdZOTTAH3SFDkLH9MqFAVQjSg1yli+Sjr7BKImICm1ypo4ooIv3FHRtL9waCTXr8N7l+cxBxRdlk5AQPeur1R;4:xynSg/Sd/mGWYxVIKYxwIM77M7wP2i4L6QGjgfgsSSOi3Qe/2AQCx91UXvOJVcbSPxbUsBTRlUyjoxFMohStUsdgA9PPAMxITck6rqn2tU3W02zBtDFy2IV4Dm9kq9endSta5XAACp6kJwArT/TJ5eCLyRRoqFlypvHiGS5mCP8tceDmXOG4mgyk2Od/3nkSKbllpHUqxtpBXsqkzQ+hQNzqQUiqn9uEFhm9VCNhfuUMghCDBRzQhMCI2N1B1/ywnGmqvY1xMY1Y7DytIWT7CQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(11241501159)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231022)(3002001)(6041248)(20161123560025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(6072148)(201708071742011);SRVR:CO1PR15MB1079;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CO1PR15MB1079; X-Forefront-PRVS: 05143A8241 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(39860400002)(366004)(346002)(376002)(199004)(11905935001)(189003)(101416001)(52116002)(6506006)(6486002)(8936002)(52396003)(6306002)(478600001)(6512007)(97736004)(966005)(16586007)(316002)(36756003)(69596002)(5890100001)(6116002)(1076002)(5660300001)(6916009)(53416004)(54906003)(81166006)(81156014)(8676002)(305945005)(7736002)(105586002)(106356001)(33646002)(50226002)(2361001)(68736007)(2351001)(25786009)(6666003)(50466002)(47776003)(48376002)(2906002)(4326008)(51416003)(86362001)(39060400002)(53936002)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:CO1PR15MB1079;H:castle.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CO1PR15MB1079;23:AwhipruoOIC506ySecp0LnGQfX3Q55p1dQ4Gs5CzE?= =?us-ascii?Q?ifX1ww019InTBFUMv+t/6igWd9QLR81O6yU4afH+wsGHqLzldDBlJtDxFE1N?= =?us-ascii?Q?5EWCUHDFrm8Z+vqBFP5JrYsTMS9xxiI7YEIodROSILs1256rwCJSrrffWgCc?= =?us-ascii?Q?EOAleDQ8n8yIRufMWhrkA/zGwWU8uKKXXvs9d9ndYEaA0K++kCZmHs155iM0?= =?us-ascii?Q?8UG29kE8ag4kmx+wLRRg1hInhbFFQ6kxeSrJIGT5YUW28omYxcX4Eo2Cot8w?= =?us-ascii?Q?OEf06RNr+Zz4XX5Tzq27bkvkiyLf+wryJluCFYvex97gX+7YJBk2ELaiaYB+?= =?us-ascii?Q?oNI23CWM7nkiF7JPyl4i9ctPSqM66XX94xUJsXSbl++V3ov2o5FBKnywg7HP?= =?us-ascii?Q?4Cc7gzAOG7CL7ocibDFYBprAGiW+tcDsKnwFKebdSZaQBHJi1gf77jo/425e?= =?us-ascii?Q?zu+3fIBSX9dknXFphL6vPtZ7NPvYGd+L3mqUlxrEAggALYrO5dCKVIftr70i?= =?us-ascii?Q?bunPKHZBMOEIppSVbGlSkJgrCBRi41JkLqr6PhYkzrpQycEknITE/t8NI9Lp?= =?us-ascii?Q?SMhPy6H5D0/QF+WiI3vAtHAMUkzPpW9FLpmTXy3+d73bWquwXe8KMX2mJads?= =?us-ascii?Q?3DvUZLw0dSxImltMDdcpkaC4PGvPV4VWqg2ZVhpJrpTnp78J20Vf7heR/N98?= =?us-ascii?Q?rie2PHAj0tzDZpubjh7lEeJe70c208gkzeAvM3vCuxWEzoJPskpNy2bTyvbE?= =?us-ascii?Q?YdWDN44tM/TvjmcpO9S37Bw+DQu2B0FnorFOecoVJyh3pZIHkNW/otqSKDj+?= =?us-ascii?Q?RHsRdzuTsBWjcx8duy1bCTIcrEfaAicVx7nYqHeayw5HVTQRBnsg1l6qCncJ?= =?us-ascii?Q?eHoANMvcTVQ7qIF/UyiQ7niXiRch8xSdULNNxBnWj+LSblKMnwajsKfCnQYM?= =?us-ascii?Q?Js92+QZHjE4YY8Hq7FcHlKvi1UsSRXwFqVQJALy2wx4W38tLduXfvHr0sT5D?= =?us-ascii?Q?N9UAiKhedNxTbZhVcDprEMnehCPF/wm5bcspbUIpm0d23htYxdz22CLY/AP6?= =?us-ascii?Q?Y0FE1ap8TAR+IaDnWBUpW09HgBbPcS5Sgnbty0MNP4jbWLL9l4rOdN4mHACi?= =?us-ascii?Q?5AVdVoHmbxX9Qh7V/LuvxQe6DLGAAdgp54OHCze7EdMi5rGm5H/3IYavHr3C?= =?us-ascii?Q?7pj81wa1BzhkfiF5444Jrbm0PexCX8ihje3GyoOTRuDsRXfNM1gdEvvrw=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1079;6:UkSrlBkGnwl9rmLd5D66sB57GzDRPCRMpihaP9hsHiwLKEBSxSbHebOIQlicr7WPSKDvzZZDkMYm0/EspbxiPaFZNmeWmsLbKvCwWlqockgpQRDYRBtokx6cBxcIAb19nV41DfgiLr/0IxYLl1OpsXEosod6HbjAkEnKPGmuHo8FVAhL2asajbiVEfaFRf0yzX49aRiROox+EJsqL5lR+IiN3lCiK7AOgicgqK4RAYJ6FaJmhsLOrSUJpOEjqyvBZdgBVDSlO9+QTl6i0mCftohVh1YG+4jJG5JLvLPMaXv5/6PspPIrIUmJ8PG3iZTdrEmI/3BXgR9GR6SgdYbusXAnEDZnPEx4qIvIPRW4uMY=;5:ksmOvBE/ZSZph1t3/mZYIpSVZ6apscTW/cfwzElsxh6vRZcDWI3aowZHubB+zhTKWee4rivSHHi8seh7ACBScz1P3Y5YcWPhG42GWU0nyIc+danen8YxyrE8uBMXnPCB420UYN7OwzMqyzdGscOqLHZWInY/7FLDYryBMX3/h5w=;24:zBr5bTBIe7wLmaFGKK2rUQO5fYYife7hRuoiPI+QMiY90iGSHtDti42OVLf+6rbPKrRQVHFiNzq8xMX5GoSumEdXYmvCJyaWs6UcaVhQz3Y=;7:5IAN3NtfYd+JtlolpqT/8KKdZrOOFVvKgVlFhZEFrUyHgkSnzCXYVRE279iTr6gCKLvzOJZpRiDgBfaNZLQ3XBNAvvQVW4dS6HHxDxzfj2CZXvu2MUP5h4RisoFbkIoXXBQkN0VRwszMKftiE8MXrLEDhJzvbPiQysWqcZfvoleq80JbsvkENB+ZlYwY2FrJv3Wu54c7g3I/lBKtyvssSKfQ1hMmMsFU7gRAmhtxH41Mpep+DW024j0RRW9G8u0N SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1079;20:tOC9py9r+HlVD1ZCZSMuneEl3NR3wWj/TiXmVZIbW5KqgspV+OyXiQue02L+xGg4AWE1m2GYbxmi8Kpwtvzl0MvZug8j9KluxPnC4Ah12jlfGeh/BV1VC/LuH/DXAY+4ARJJVbS+FW23s6/J513fdZQeWXTK+Z1DSkx79Z2K4tQ= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2017 18:39:32.7802 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bebbb3e9-3a7c-475e-53c1-08d53da1dcee X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR15MB1079 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-07_08:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patchset adds basic cgroup bpf operations to bpftool. Right now there is no convenient way to perform these operations. The /samples/bpf/load_sock_ops.c implements attach/detacg operations, but only for BPF_CGROUP_SOCK_OPS programs. Bps (part of bcc) implements bpf introspection, but lacks any cgroup-related specific. I find having a tool to perform these basic operations in the kernel tree very useful, as it can be used in the corresponding bpf documentation without creating additional dependencies. And bpftool seems to be a right tool to extend with such functionality. v2: - Added prog load operations - All cgroup operations are looking like bpftool cgroup - All cgroup-related stuff is moved to a separate file - Added support for attach flags - Added support for attaching/detaching programs by id, pinned name, etc - Changed cgroup detach arguments order - Added empty json output for succesful programs - Style fixed: includes order, strncmp and macroses, error handling - Added man pages v1: https://lwn.net/Articles/740366/ Roman Gushchin (4): libbpf: add ability to guess program type based on section name libbpf: prefer global symbols as bpf program name source bpftool: implement prog load command bpftool: implement cgroup bpf operations tools/bpf/bpftool/Documentation/bpftool-cgroup.rst | 92 +++++++ tools/bpf/bpftool/Documentation/bpftool-map.rst | 2 +- tools/bpf/bpftool/Documentation/bpftool-prog.rst | 12 +- tools/bpf/bpftool/Documentation/bpftool.rst | 8 +- tools/bpf/bpftool/cgroup.c | 305 +++++++++++++++++++++ tools/bpf/bpftool/common.c | 71 ++--- tools/bpf/bpftool/main.c | 3 +- tools/bpf/bpftool/main.h | 2 + tools/bpf/bpftool/prog.c | 31 ++- tools/lib/bpf/libbpf.c | 53 ++++ 10 files changed, 540 insertions(+), 39 deletions(-) create mode 100644 tools/bpf/bpftool/Documentation/bpftool-cgroup.rst create mode 100644 tools/bpf/bpftool/cgroup.c -- 2.14.3