From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: mhocko@kernel.org
Cc: rientjes@google.com, akpm@linux-foundation.org,
aarcange@redhat.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: Multiple oom_reaper BUGs: unmap_page_range racing with exit_mmap
Date: Thu, 7 Dec 2017 20:00:58 +0900 [thread overview]
Message-ID: <201712072000.FCE30281.FOFHOOtVMQLJFS@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <20171207082801.GB20234@dhcp22.suse.cz>
Michal Hocko wrote:
> Hmm, so you are creating a separate process (from the signal point of
> view) and I suspect it is one of those that holds the last reference to
> the mm_struct which is released here and it has tsk_oom_victim = F
Right.
> So we need a more robust test for the oom victim. Your suggestion is
> basically what I came up with originally [1] and which was deemed
> ineffective because we took the mmap_sem even for regular paths and
> Kirill was afraid this adds some unnecessary cycles to the exit path
> which is quite hot.
>
> So I guess we have to do something else instead. We have to store the
> oom flag to the mm struct as well. Something like the patch below.
Yes, adding a new flag for this purpose will work.
Also, setting MMF_UNSTABLE flag between after sending SIGKILL and before
victim->mm becomes NULL and testing MMF_UNSTABLE at exit_mm() should work.
But I prefer simple revert + mmget()/mmput_async() approach at
http://lkml.kernel.org/r/201712062037.DAF90168.SVFQOJFMOOtHLF@I-love.SAKURA.ne.jp , for
my approach not only saves lines but also fixes unexpected change for nommu at
http://lkml.kernel.org/r/201711091949.BDB73475.OSHFOMQtLFOFVJ@I-love.SAKURA.ne.jp .
Also, if we replace asynchronous OOM reaping by the OOM reaper kernel thread with
synchronous OOM reaping by the OOM killer, we can close MMF_OOM_SKIP race window
because it is guaranteed that __oom_reap_task_mm() is called before __mmput() is
called.
next prev parent reply other threads:[~2017-12-07 11:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 2:43 Multiple oom_reaper BUGs: unmap_page_range racing with exit_mmap David Rientjes
2017-12-06 2:58 ` David Rientjes
[not found] ` <201712060328.vB63SrDK069830@www262.sakura.ne.jp>
2017-12-06 7:48 ` David Rientjes
2017-12-06 9:00 ` Michal Hocko
[not found] ` <201712070720.vB77KlBQ009754@www262.sakura.ne.jp>
2017-12-07 8:28 ` Michal Hocko
2017-12-07 8:44 ` Michal Hocko
2017-12-07 11:00 ` Tetsuo Handa [this message]
2017-12-07 21:22 ` David Rientjes
2017-12-08 7:50 ` Michal Hocko
2017-12-06 11:37 ` Tetsuo Handa
2017-12-06 8:50 ` Michal Hocko
2017-12-06 8:31 ` Michal Hocko
2017-12-07 11:35 ` Michal Hocko
2017-12-07 15:44 ` Tetsuo Handa
2017-12-07 16:30 ` Michal Hocko
2017-12-07 21:55 ` David Rientjes
2017-12-08 9:26 ` David Rientjes
2017-12-08 11:27 ` Michal Hocko
2017-12-08 10:11 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201712072000.FCE30281.FOFHOOtVMQLJFS@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).