From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752512AbdLHHmr (ORCPT ); Fri, 8 Dec 2017 02:42:47 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:38972 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751021AbdLHHmq (ORCPT ); Fri, 8 Dec 2017 02:42:46 -0500 Date: Fri, 8 Dec 2017 08:42:52 +0100 From: Greg Kroah-Hartman To: "Tobin C. Harding" Cc: Joe Perches , linux-kernel@vger.kernel.org, Andy Whitcroft Subject: Re: [PATCH 4/4] checkpatch: add check for tag Co-Developed-by Message-ID: <20171208074252.GA16137@kroah.com> References: <1512689271-28051-1-git-send-email-me@tobin.cc> <1512689271-28051-5-git-send-email-me@tobin.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512689271-28051-5-git-send-email-me@tobin.cc> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 08, 2017 at 10:27:51AM +1100, Tobin C. Harding wrote: > From: Joe Perches > > Recently signature tag Co-Developed-by was added to the > kernel (Documentation/process/5.Posting.rst). checkpatch.pl doesn't know > about it yet. All prior tags used all lowercase characters except for first > character. Checks for this format had to be re-worked to allow for the > new tag. > > Cc: Greg Kroah-Hartman > > Reviewed-by: Greg Kroah-Hartman > Signed-off-by: Tobin C. Harding > --- > > Greg, > > This patch has the same brief commit and achieves the same aim as the > code you reviewed. I'm adding your tag here even though the code is > totally different. I believe you were reviewing the behaviour of the > code not the actual logic. Well, I did read the actual logic, I do know perl :) Anyway, my reviewed-by still stands here, thanks. greg k-h