From: Masami Hiramatsu <mhiramat@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: bhargavb <bhargavaramudu@gmail.com>,
linux-kernel@vger.kernel.org, Paul Clarke <pc@us.ibm.com>,
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>,
linux-rt-users@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 1/5] perf-probe: Add warning message if there is unexpected event name
Date: Fri, 8 Dec 2017 11:48:48 +0900 [thread overview]
Message-ID: <20171208114848.1a0e77e423e1ca14b9552bf7@kernel.org> (raw)
In-Reply-To: <20171207155343.GC3173@kernel.org>
On Thu, 7 Dec 2017 12:53:43 -0300
Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Em Thu, Dec 07, 2017 at 04:19:45PM +0900, Masami Hiramatsu escreveu:
> > This improve the error message so that user can know
> > event-name error before writing new events to
> > kprobe-events interface.
> >
> > E.g.
> > ======
> > #./perf probe -x /lib64/libc-2.25.so malloc_get_state*
> > Internal error: "malloc_get_state@GLIBC_2" is wrong event name.
>
> I'm changing this to:
>
> Internal error: "malloc_get_state@GLIBC_2" is an invalid event name for the /sys/kernel/debug/tracing/kprobe_events interface.
>
> Ok?
Hmm, it is a kernel limitation (or spec). Would you think we really need it?
(are there any chance to allow '@' for event name?)
Thank you,
>
> - Arnaldo
>
> > Error: Failed to add events.
> > ======
> >
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> > ---
> > tools/perf/util/probe-event.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> > index b7aaf9b2294d..c0067950e56f 100644
> > --- a/tools/perf/util/probe-event.c
> > +++ b/tools/perf/util/probe-event.c
> > @@ -2625,6 +2625,14 @@ static int get_new_event_name(char *buf, size_t len, const char *base,
> >
> > out:
> > free(nbase);
> > +
> > + /* Final validation */
> > + if (ret >= 0 && !is_c_func_name(buf)) {
> > + pr_warning("Internal error: \"%s\" is wrong event name.\n",
> > + buf);
> > + ret = -EINVAL;
> > + }
> > +
> > return ret;
> > }
> >
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2017-12-08 2:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 7:19 [PATCH v2 0/5] perf-probe: Improve probing on versioned symbols Masami Hiramatsu
2017-12-07 7:19 ` [PATCH v2 1/5] perf-probe: Add warning message if there is unexpected event name Masami Hiramatsu
2017-12-07 15:53 ` Arnaldo Carvalho de Melo
2017-12-08 2:48 ` Masami Hiramatsu [this message]
2017-12-07 7:20 ` [PATCH v2 2/5] perf-probe: Cut off the version suffix from " Masami Hiramatsu
2017-12-07 16:34 ` Paul Clarke
2017-12-08 3:01 ` Masami Hiramatsu
2017-12-08 14:49 ` Paul Clarke
2017-12-08 16:12 ` Masami Hiramatsu
2017-12-11 18:25 ` Arnaldo Carvalho de Melo
2017-12-12 15:02 ` Masami Hiramatsu
2017-12-07 16:56 ` Arnaldo Carvalho de Melo
2017-12-07 17:24 ` Paul Clarke
2017-12-07 17:55 ` Arnaldo Carvalho de Melo
2017-12-08 3:15 ` Masami Hiramatsu
2017-12-07 7:20 ` [PATCH v2 3/5] perf-probe: Add __return suffix for return events Masami Hiramatsu
2017-12-07 7:21 ` [PATCH v2 4/5] perf-probe: Find versioned symbols from map Masami Hiramatsu
2017-12-08 11:08 ` Thomas-Mich Richter
2017-12-08 14:22 ` Masami Hiramatsu
2017-12-07 7:21 ` [PATCH v2 5/5] perf-probe: Support escaped character in parser Masami Hiramatsu
2017-12-08 11:45 ` Thomas-Mich Richter
2017-12-08 15:54 ` Masami Hiramatsu
2017-12-07 12:47 ` [PATCH v2 0/5] perf-probe: Improve probing on versioned symbols Ravi Bangoria
2017-12-08 16:24 ` Masami Hiramatsu
2017-12-08 17:13 ` Ravi Bangoria
2017-12-08 11:56 ` Thomas-Mich Richter
2017-12-08 16:12 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208114848.1a0e77e423e1ca14b9552bf7@kernel.org \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=bhargavaramudu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=pc@us.ibm.com \
--cc=ravi.bangoria@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).