From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753460AbdLHNFQ (ORCPT ); Fri, 8 Dec 2017 08:05:16 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:41794 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753308AbdLHNFL (ORCPT ); Fri, 8 Dec 2017 08:05:11 -0500 X-Google-Smtp-Source: AGs4zMadhWe2mFhsoa7IPLio5AArzLAfPfO9dLDvRRiiBfOJIeUfO+/eaLf0b99MWb0BpPiSYxjLFQ== Date: Fri, 8 Dec 2017 22:02:24 +0900 From: Namhyung Kim To: Tom Zanussi Cc: rostedt@goodmis.org, tglx@linutronix.de, mhiramat@kernel.org, vedang.patel@intel.com, bigeasy@linutronix.de, joel.opensrc@gmail.com, joelaf@google.com, mathieu.desnoyers@efficios.com, baohong.liu@intel.com, rajvi.jingar@intel.com, julia@ni.com, fengguang.wu@intel.com, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, kernel-team@lge.com Subject: Re: [PATCH v7 15/37] tracing: Add variable support to hist triggers Message-ID: <20171208130224.GA7312@danjae.aot.lge.com> References: <04af0ae029bd09e4f7b163d7793e094fe4b1163a.1512593081.git.tom.zanussi@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <04af0ae029bd09e4f7b163d7793e094fe4b1163a.1512593081.git.tom.zanussi@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tom, On Wed, Dec 06, 2017 at 04:37:56PM -0600, Tom Zanussi wrote: > Add support for saving the value of a current event's event field by > assigning it to a variable that can be read by a subsequent event. > > The basic syntax for saving a variable is to simply prefix a unique > variable name not corresponding to any keyword along with an '=' sign > to any event field. > > Both keys and values can be saved and retrieved in this way: > > # echo 'hist:keys=next_pid:vals=$ts0:ts0=common_timestamp ... > # echo 'hist:timer_pid=common_pid:key=$timer_pid ...' > > If a variable isn't a key variable or prefixed with 'vals=', the > associated event field will be saved in a variable but won't be summed > as a value: > > # echo 'hist:keys=next_pid:ts1=common_timestamp:... > > Multiple variables can be assigned at the same time: > > # echo 'hist:keys=pid:vals=$ts0,$b,field2:ts0=common_timestamp,b=field1 ... > > Multiple (or single) variables can also be assigned at the same time > using separate assignments: > > # echo 'hist:keys=pid:vals=$ts0:ts0=common_timestamp:b=field1:c=field2 ... > > Variables set as above can be used by being referenced from another > event, as described in a subsequent patch. > > Signed-off-by: Tom Zanussi > Signed-off-by: Baohong Liu > --- [SNIP] > @@ -962,14 +1201,28 @@ static void hist_trigger_elt_update(struct hist_trigger_data *hist_data, > struct ring_buffer_event *rbe) > { > struct hist_field *hist_field; > - unsigned int i; > + unsigned int i, var_idx; > u64 hist_val; > > for_each_hist_val_field(i, hist_data) { > hist_field = hist_data->fields[i]; > - hist_val = hist_field->fn(hist_field, rec, rbe); > + hist_val = hist_field->fn(hist_field, rbe, rec); Why is this changed? > + if (hist_field->flags & HIST_FIELD_FL_VAR) { > + var_idx = hist_field->var.idx; > + tracing_map_set_var(elt, var_idx, hist_val); > + continue; > + } > tracing_map_update_sum(elt, i, hist_val); > } > + > + for_each_hist_key_field(i, hist_data) { > + hist_field = hist_data->fields[i]; > + if (hist_field->flags & HIST_FIELD_FL_VAR) { > + hist_val = hist_field->fn(hist_field, rbe, rec); Also it seems to have a wrong argument order. Thanks, Namhyung > + var_idx = hist_field->var.idx; > + tracing_map_set_var(elt, var_idx, hist_val); > + } > + } > }