From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
"Liu, Changcheng" <changcheng.liu@intel.com>,
sergey.senozhatsky@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/slabinfo-gnuplot: force to use bash shell
Date: Sat, 9 Dec 2017 08:59:00 +0900 [thread overview]
Message-ID: <20171208235900.GE489@tigerII.localdomain> (raw)
In-Reply-To: <20171208140246.bc111cc726d5f7f8ff7c2ed2@linux-foundation.org>
On (12/08/17 14:02), Andrew Morton wrote:
> > On (12/08/17 17:37), Liu, Changcheng wrote:
> > >
> > > On some linux distributions, the default link of sh
> > > is dash which deoesn't support split array like
> > > ${var//,/ }
> > > It's better to force to use bash shell directly.
> > >
> > > Signed-off-by: Liu Changcheng <changcheng.liu@intel.com>
> >
> > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
>
> It would be better to rewrite the script to avoid bashisms.
Hello Andrew,
what are the latest fashion trends? isn't it perl? so maybe
I can sit down someday and rewrite it in perl.
-ss
prev parent reply other threads:[~2017-12-08 23:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 9:37 [PATCH] tools/slabinfo-gnuplot: force to use bash shell Liu, Changcheng
2017-12-08 10:33 ` Sergey Senozhatsky
2017-12-08 22:02 ` Andrew Morton
2017-12-08 22:20 ` Joe Perches
2017-12-08 23:59 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208235900.GE489@tigerII.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=changcheng.liu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).