From: Darren Hart <dvhart@infradead.org>
To: Peter Hutterer <peter.hutterer@who-t.net>
Cc: "Corentin Chary" <corentin.chary@gmail.com>,
"João Paulo Rechi Vita" <jprvita@gmail.com>,
"Andy Shevchenko" <andy@infradead.org>,
acpi4asus-user@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] asus-wireless: send an EV_SYN/SYN_REPORT between state changes
Date: Fri, 8 Dec 2017 16:10:58 -0800 [thread overview]
Message-ID: <20171209001058.GE14187@fury> (raw)
In-Reply-To: <20171204002617.GA11430@jelly>
On Mon, Dec 04, 2017 at 10:26:17AM +1000, Peter Hutterer wrote:
> Sending the switch state change twice within the same frame is invalid evdev
> protocol and only works if the client handles keys immediately as well.
> Processing events immediately is incorrect, it forces a fake order of events
> that does not exist on the device.
>
> Recent versions of libinput changed to only process the device state and
> SYN_REPORT time, so now the key event is lost.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=104041
>
> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Thanks Peter, queued.
--
Darren Hart
VMware Open Source Technology Center
prev parent reply other threads:[~2017-12-09 0:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 0:26 [PATCH] asus-wireless: send an EV_SYN/SYN_REPORT between state changes Peter Hutterer
2017-12-09 0:10 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171209001058.GE14187@fury \
--to=dvhart@infradead.org \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=andy@infradead.org \
--cc=corentin.chary@gmail.com \
--cc=jprvita@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).