From: "Tobin C. Harding" <me@tobin.cc>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH 4/4] checkpatch: add check for tag Co-Developed-by
Date: Sat, 9 Dec 2017 12:18:45 +1100 [thread overview]
Message-ID: <20171209011845.GA2191@eros> (raw)
In-Reply-To: <20171208074252.GA16137@kroah.com>
On Fri, Dec 08, 2017 at 08:42:52AM +0100, Greg Kroah-Hartman wrote:
> On Fri, Dec 08, 2017 at 10:27:51AM +1100, Tobin C. Harding wrote:
> > From: Joe Perches <joe@perches.com>
> >
> > Recently signature tag Co-Developed-by was added to the
> > kernel (Documentation/process/5.Posting.rst). checkpatch.pl doesn't know
> > about it yet. All prior tags used all lowercase characters except for first
> > character. Checks for this format had to be re-worked to allow for the
> > new tag.
> >
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Tobin C. Harding <me@tobin.cc>
> > ---
> >
> > Greg,
> >
> > This patch has the same brief commit and achieves the same aim as the
> > code you reviewed. I'm adding your tag here even though the code is
> > totally different. I believe you were reviewing the behaviour of the
> > code not the actual logic.
>
> Well, I did read the actual logic, I do know perl :)
No offense meant, just trying to make your day easier.
> Anyway, my reviewed-by still stands here, thanks.
thanks,
Tobin.
prev parent reply other threads:[~2017-12-09 1:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 23:27 [PATCH 0/4] checkpatch: update warnings Tobin C. Harding
2017-12-07 23:27 ` [PATCH 1/4] checkpatch: add sub routine get_stat_real() Tobin C. Harding
2017-12-07 23:27 ` [PATCH 2/4] checkpatch: add sub routine get_stat_here() Tobin C. Harding
2017-12-07 23:27 ` [PATCH 3/4] checkpatch: warn for use of %px Tobin C. Harding
2017-12-07 23:27 ` [PATCH 4/4] checkpatch: add check for tag Co-Developed-by Tobin C. Harding
2017-12-08 7:42 ` Greg Kroah-Hartman
2017-12-09 1:18 ` Tobin C. Harding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171209011845.GA2191@eros \
--to=me@tobin.cc \
--cc=apw@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).