From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751131AbdLIFrc (ORCPT ); Sat, 9 Dec 2017 00:47:32 -0500 Received: from mail.cn.fujitsu.com ([183.91.158.132]:38050 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750817AbdLIFr1 (ORCPT ); Sat, 9 Dec 2017 00:47:27 -0500 X-IronPort-AV: E=Sophos;i="5.43,368,1503331200"; d="scan'208";a="30926778" From: Ma Shimiao To: , CC: , , Ma Shimiao Subject: [PATCH] cgroup: limit max copied char length for cgroup file name Date: Sat, 9 Dec 2017 13:47:58 +0800 Message-ID: <20171209054758.13870-1-mashimiao.fnst@cn.fujitsu.com> X-Mailer: git-send-email 2.13.6 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.167.225.93] X-yoursite-MailScanner-ID: 5C9F8486A76B.AE6B2 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: mashimiao.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org the result of cgroup_file_name will be used by kernfs_remove_name, and then by kernfs_remove_by_name_ns(). If reached the max length, may have problem printed by WARN() in kernfs_remove_by_name_ns(). Signed-off-by: Ma Shimiao --- kernel/cgroup/cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 0b1ffe147f24..7f588d1617c5 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -1397,7 +1397,7 @@ static char *cgroup_file_name(struct cgroup *cgrp, const struct cftype *cft, cgroup_on_dfl(cgrp) ? ss->name : ss->legacy_name, cft->name); else - strncpy(buf, cft->name, CGROUP_FILE_NAME_MAX); + strncpy(buf, cft->name, CGROUP_FILE_NAME_MAX - 1); return buf; } -- 2.13.6