From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752155AbdLJMgc (ORCPT ); Sun, 10 Dec 2017 07:36:32 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:47038 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709AbdLJMga (ORCPT ); Sun, 10 Dec 2017 07:36:30 -0500 Date: Sun, 10 Dec 2017 13:36:37 +0100 From: Greg Kroah-Hartman To: Thomas Backlund Cc: Ivan Kozik , linux-kernel@vger.kernel.org, Linus Torvalds , akpm@linux-foundation.org, Guenter Roeck , Shuah Khan , patches@kernelci.org, Ben Hutchings , lkft-triage@lists.linaro.org, stable@vger.kernel.org Subject: Re: [PATCH 4.14 00/75] 4.14.5-stable review Message-ID: <20171210123637.GA12241@kroah.com> References: <20171207130818.742746317@linuxfoundation.org> <20171209074544.GA1770@kroah.com> <20171209171349.GA26021@kroah.com> <1b8f1c5e-f616-0e10-2ce2-8bd07e4260d8@mageia.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1b8f1c5e-f616-0e10-2ce2-8bd07e4260d8@mageia.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 09, 2017 at 07:32:38PM +0200, Thomas Backlund wrote: > Den 09.12.2017 kl. 19:13, skrev Greg Kroah-Hartman: > > On Sat, Dec 09, 2017 at 07:56:40AM +0000, Ivan Kozik wrote: > > > On Sat, Dec 9, 2017 at 7:45 AM, Greg Kroah-Hartman > > > wrote: > > > > On Sat, Dec 09, 2017 at 03:34:24AM +0000, Ivan Kozik wrote: > > > > > I saw no problems on 8 of 9 machines, but the last one had a problem > > > > > because it used NVIDIA drivers (387); DKMS reported: > > > > > > > > > > FATAL: modpost: GPL-incompatible module nvidia-drm.ko uses GPL-only > > > > > symbol 'ex_handler_refcount' > > > > > //usr/src/linux-headers-4.14.0-11-common/scripts/Makefile.modpost:92: > > > > > recipe for target '__modpost' failed > > > > > make[3]: *** [__modpost] Error 1 > > > > > > > > Is this a new issue? Does 4.14.4 have this issue? > > > > > > I believe it is a new issue, because I have a 4.14.4 build and an > > > NVIDIA DKMS log for that 4.14.4 showing build success. > > > > > > > Odd, is 564c9cc84e2a ("locking/refcounts, x86/asm: Use unique .text > > > > section for refcount exceptions") causing this? > > > > > > That was my guess too, but I did not verify. > > > > That feels really wrong here, I'd like to get some confirmation before I > > add this patch... > > > > It's needed. > > The reason you hit in 4.14.5 queue is because of: > > [PATCH 4.14 64/75] locking/refcounts, x86/asm: Enable > CONFIG_ARCH_HAS_REFCOUNT > > From foo@baz Wed Dec 6 18:04:41 CET 2017 > From: Kees Cook > Date: Sat, 2 Sep 2017 13:09:46 -0700 > Subject: locking/refcounts, x86/asm: Enable CONFIG_ARCH_HAS_REFCOUNT > > > that does this: > > - select ARCH_HAS_REFCOUNT if BROKEN > + select ARCH_HAS_REFCOUNT > > > > So it exposes previously hidden code.... Ah yes, thanks for the explaination. I've queued up that patch now. greg k-h