From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752876AbdLKLq5 (ORCPT ); Mon, 11 Dec 2017 06:46:57 -0500 Received: from [128.1.224.119] ([128.1.224.119]:43956 "EHLO ringil.hmeau.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752403AbdLKLqu (ORCPT ); Mon, 11 Dec 2017 06:46:50 -0500 Date: Mon, 11 Dec 2017 22:46:14 +1100 From: Herbert Xu To: Colin King Cc: Harsh Jain , "avid S . Miller" , linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: chelsio: make arrays sgl_ent_len and dsgl_ent_len static Message-ID: <20171211114614.GH12014@gondor.apana.org.au> References: <20171130113208.3381-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171130113208.3381-1-colin.king@canonical.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 30, 2017 at 11:32:08AM +0000, Colin King wrote: > From: Colin Ian King > > The arrays sgl_ent_len and dsgl_ent_len are local to the source and do > not need to be in global scope, so make them static. Also re-format the > declarations to match the following round_constant array declaration > style. > > Cleans up sparse warnings: > drivers/crypto/chelsio/chcr_algo.c:76:14: warning: symbol 'sgl_ent_len' > was not declared. Should it be static? > drivers/crypto/chelsio/chcr_algo.c:81:14: warning: symbol 'dsgl_ent_len' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt