From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752861AbdLKMrc (ORCPT ); Mon, 11 Dec 2017 07:47:32 -0500 Received: from foss.arm.com ([217.140.101.70]:57002 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752470AbdLKMrb (ORCPT ); Mon, 11 Dec 2017 07:47:31 -0500 Date: Mon, 11 Dec 2017 12:47:38 +0000 From: Will Deacon To: Heiko Carstens , mingo@kernel.org Cc: linux-kernel@vger.kernel.org, sebott@linux.vnet.ibm.com, schwidefsky@de.ibm.com, peterz@infradead.org Subject: Re: [PATCH 0/2] Fix boot regression for s390 and remove break_lock Message-ID: <20171211124738.GF26810@arm.com> References: <1511894539-7988-1-git-send-email-will.deacon@arm.com> <20171202090207.GA5046@osiris> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171202090207.GA5046@osiris> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 02, 2017 at 10:02:08AM +0100, Heiko Carstens wrote: > On Tue, Nov 28, 2017 at 06:42:17PM +0000, Will Deacon wrote: > > The following two patches do the following: > > > > 1. Fix boot breakage reported on s390 caused by a8a217c22116 > > 2. Kill off the break_lock field entirely, since it's not actually > > that useful > > > > I didn't go the whole hog and remove CONFIG_GENERIC_LOCKBREAK, since the > > "do something different with locks in preemptible kernels" isn't necessarily > > a bad idea, and PowerPC actually implements things like arch_spin_relax > > for that. > > > > The first patch should go in to 4.15. > > > > Thanks, > > > > Will > > > > --->8 > > > > Will Deacon (2): > > locking/core: Fix deadlock during boot on systems with > > GENERIC_LOCKBREAK > > locking/core: Remove break_lock field when CONFIG_GENERIC_LOCKBREAK=y > > > > include/linux/rwlock_types.h | 3 --- > > include/linux/spinlock.h | 5 ----- > > include/linux/spinlock_types.h | 3 --- > > kernel/locking/spinlock.c | 13 +++---------- > > 4 files changed, 3 insertions(+), 21 deletions(-) > > *ping* ... these patches haven't been picked up yet as far as I can tell. > Peter, Ingo? Damn, this first patch didn't appear in -rc3. Ingo -- please can you pick this up? Without it, s390 doesn't boot with mainline. Thanks, Will