From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Anand, Jerome" <jerome.anand@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"Chen, Augustine" <augustine.chen@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Bossart, Pierre-louis" <pierre-louis.bossart@intel.com>,
"tiwai@suse.de" <tiwai@suse.de>, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Jiang Liu <jiang.liu@linux.intel.com>,
Juergen Gross <jgross@suse.com>,
Dou Liyang <douly.fnst@cn.fujitsu.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio
Date: Mon, 11 Dec 2017 15:20:23 +0200 [thread overview]
Message-ID: <20171211132023.GO10981@intel.com> (raw)
In-Reply-To: <F6867404AABACB4D8EC371BF802A4B7C5790D206@fmsmsx101.amr.corp.intel.com>
On Mon, Dec 11, 2017 at 08:33:33AM +0000, Anand, Jerome wrote:
>
>
> > -----Original Message-----
> > From: Thomas Gleixner [mailto:tglx@linutronix.de]
> > Sent: Saturday, December 9, 2017 4:22 AM
> > To: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Chen, Augustine <augustine.chen@intel.com>; intel-
> > gfx@lists.freedesktop.org; alsa-devel@alsa-project.org; Anand, Jerome
> > <jerome.anand@intel.com>; Bossart, Pierre-louis <pierre-
> > louis.bossart@intel.com>; tiwai@suse.de; Ingo Molnar <mingo@redhat.com>;
> > H. Peter Anvin <hpa@zytor.com>; Jiang Liu <jiang.liu@linux.intel.com>; Juergen
> > Gross <jgross@suse.com>; Dou Liyang <douly.fnst@cn.fujitsu.com>; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove unused IRQ chip data of
> > HDMI LPE audio
> >
> > On Fri, 8 Dec 2017, Ville Syrjälä wrote:
> >
> > > On Fri, Dec 08, 2017 at 05:33:23PM +0800, Augustine.Chen wrote:
> > > > The chip data of HDMI LPE audio is set to drm_i915_private which is
> > > > not consistent with the expectation by x86 APIC driver.
> > >
> > > Hmm. Why is the apic code looking at data for an irq chip it hasn't
> > > created?
> > >
>
> apic code expects an irq domain to be place as generic approach.
>
> > > Do we need something like
> > > - dev_priv->lpe_audio.irq = irq_alloc_desc(0);
> > > + dev_priv->lpe_audio.irq = irq_alloc_desc(-1);
> >
> > #define irq_alloc_desc(node)
> >
> > So instead of handing in node 0 you hand in node -1 which is NUMA_NO_NODE
> >
Ah. I misread the macros. So we already pass irq=-1.
>
> Agree - am not sure whether it will make any difference.
>
> > > That *looks* more correct to me based on a cursory glance at the x86
> > > code, but I didn't trawl very deeply.
> >
> > The x86 core cares not at all about interrupt chips which are created in a driver
> > and not connected to an actual apic/ioapic/msi interrupt. This interrupt chip is
> > its own thing as we have others in GPIO etc.
> >
> > > > In the case of not enabling CONFIG_CPUMASK_OFFSTACK, this would
> > > > cause kernel panic while doing CPU hotplug.
> >
> > And why so? Surely not because you set irq_chip_data. That's really no
> > explanation at all.
> >
>
> Ideally, I feel there needs to be an irq domain for mapping the irq numbers with hwirq.
> It is not created as part of the hdmi lpe audio bridge.
> Since the logic to mask/unmask lpe audio interrupts is removed, there is no need of the
> Chip data or creation of the domain now.
There is no need right now. But there might be a need in the future.
LPE audio isn't even the only piece of hardware whose irq goes through
the i915 display engine (there's also the ISP and VED). So I would
much prefer a proper solution instead of sweeping the problem under
the rug.
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2017-12-11 13:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171208093323.2212-1-augustine.chen@intel.com>
2017-12-08 11:44 ` [Intel-gfx] [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio Ville Syrjälä
2017-12-08 22:51 ` Thomas Gleixner
2017-12-11 8:33 ` Anand, Jerome
2017-12-11 13:20 ` Ville Syrjälä [this message]
2017-12-11 13:23 ` Takashi Iwai
2017-12-12 9:26 ` Chen, Augustine
2017-12-12 9:45 ` Takashi Iwai
2017-12-13 9:25 ` Chen, Augustine
2017-12-12 17:06 ` Thomas Gleixner
2017-12-13 2:15 ` Anand, Jerome
2017-12-13 11:35 ` Thomas Gleixner
2017-12-13 11:52 ` Takashi Iwai
2017-12-13 14:06 ` Thomas Gleixner
2018-01-29 17:09 ` Ville Syrjälä
2018-02-20 18:49 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211132023.GO10981@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=augustine.chen@intel.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jerome.anand@intel.com \
--cc=jgross@suse.com \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pierre-louis.bossart@intel.com \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).