From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753050AbdLMCuC (ORCPT <rfc822;w@1wt.eu>);
        Tue, 12 Dec 2017 21:50:02 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:59190 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752815AbdLMB5E (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Dec 2017 20:57:04 -0500
Date: Tue, 12 Dec 2017 20:57:01 -0500 (EST)
Message-Id: <20171212.205701.569779668163323943.davem@davemloft.net>
To: stephen@networkplumber.org
Cc: baijiaju1990@gmail.com, mlindner@marvell.com, shemminger@osdl.org,
        shemminger@linux-foundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [BUG] skge: a possible sleep-in-atomic bug in skge_remove
From: David Miller <davem@davemloft.net>
In-Reply-To: <20171212102240.4a09cf9a@xeon-e3>
References: <1e8a8196-f0d1-2a82-3632-b882787c4391@gmail.com>
        <20171212.083445.2256119006373036925.davem@davemloft.net>
        <20171212102240.4a09cf9a@xeon-e3>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 12 Dec 2017 17:57:04 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Stephen Hemminger <stephen@networkplumber.org>
Date: Tue, 12 Dec 2017 10:22:40 -0800

> On Tue, 12 Dec 2017 08:34:45 -0500 (EST)
> David Miller <davem@davemloft.net> wrote:
> 
>> From: Jia-Ju Bai <baijiaju1990@gmail.com>
>> Date: Tue, 12 Dec 2017 16:38:12 +0800
>> 
>> > According to drivers/net/ethernet/marvell/skge.c, the driver may sleep
>> > under a spinlock.
>> > The function call path is:
>> > skge_remove (acquire the spinlock)
>> >   free_irq --> may sleep
>> > 
>> > I do not find a good way to fix it, so I only report.
>> > This possible bug is found by my static analysis tool (DSAC) and
>> > checked by my code review.  
>> 
>> This was added by:
>> 
>> commit a9e9fd7182332d0cf5f3e601df3e71dd431b70d7
>> Author: Stephen Hemminger <shemminger@vyatta.com>
>> Date:   Tue Sep 27 13:41:37 2011 -0400
>> 
>>     skge: handle irq better on single port card
>> 
>> I think the free_irq() can be moved below the unlock.
>> 
>> Stephen, please take a look.
> 
> The IRQ was being free twice.
> How did you see it, I really doubt any multi-port SKGE cards
> still exist.

He sees it by reading the code, please take a look at this
and move the free_irq() out of the spin locked section since
it can sleep.