From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752208AbdLLJfp (ORCPT ); Tue, 12 Dec 2017 04:35:45 -0500 Received: from mail.cn.fujitsu.com ([183.91.158.132]:52147 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751053AbdLLJfm (ORCPT ); Tue, 12 Dec 2017 04:35:42 -0500 X-IronPort-AV: E=Sophos;i="5.43,368,1503331200"; d="scan'208";a="31262936" From: Ma Shimiao To: , CC: , , Ma Shimiao Subject: [PATCH] drviers/nvme/target: fix max dup length for kstrndup Date: Tue, 12 Dec 2017 17:36:39 +0800 Message-ID: <20171212093639.21274-1-mashimiao.fnst@cn.fujitsu.com> X-Mailer: git-send-email 2.13.6 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.167.225.93] X-yoursite-MailScanner-ID: 8137148AE826.AAB2B X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: mashimiao.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If source string longer than max, kstrndup will alloc max+1 space. So, we should make sure the result will not over limit. Signed-off-by: Ma Shimiao --- drivers/nvme/target/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index b54748ad5f48..0ca259ee4dea 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c @@ -975,7 +975,7 @@ struct nvmet_subsys *nvmet_subsys_alloc(const char *subsysnqn, return NULL; } subsys->type = type; - subsys->subsysnqn = kstrndup(subsysnqn, NVMF_NQN_SIZE, + subsys->subsysnqn = kstrndup(subsysnqn, NVMF_NQN_SIZE - 1, GFP_KERNEL); if (!subsys->subsysnqn) { kfree(subsys); -- 2.13.6