linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Michael Ira Krufky <mkrufky@linuxtv.org>,
	linux-media <linux-media@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tuners: tda8290: reduce stack usage with kasan
Date: Tue, 12 Dec 2017 10:45:30 -0200	[thread overview]
Message-ID: <20171212104530.46ac4ffe@vento.lan> (raw)
In-Reply-To: <1513078952.3036.36.camel@perches.com>

Em Tue, 12 Dec 2017 03:42:32 -0800
Joe Perches <joe@perches.com> escreveu:

> > I actually thought about marking them 'const' here before sending
> > (without noticing the changelog text) and then ran into what must
> > have led me to drop the 'const' originally: tuner_i2c_xfer_send()
> > takes a non-const pointer. This can be fixed but it requires
> > an ugly cast:  
> 
> Casting away const is always a horrible hack.
> 
> Until it could be changed, my preference would
> be to update the changelog and perhaps add to
> the changelog the reason why it can not be const
> as detailed below.
> 
> ie: xfer_send and xfer_xend_recv both take a
>     non-const unsigned char *

Perhaps, on a separate changeset, we could change I2C routines to
accept const unsigned char pointers. This is unrelated to tda8290
KASAN fixes. So, it should go via I2C tree, and, once accepted
there, we can change V4L2 drivers (and other drivers) accordingly.


Thanks,
Mauro

  reply	other threads:[~2017-12-12 12:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-11 12:06 [PATCH] tuners: tda8290: reduce stack usage with kasan Arnd Bergmann
2017-12-11 15:09 ` Michael Ira Krufky
2017-12-11 19:34 ` Joe Perches
2017-12-11 21:17   ` Michael Ira Krufky
2017-12-12 10:24     ` Arnd Bergmann
2017-12-12 11:42       ` Joe Perches
2017-12-12 12:45         ` Mauro Carvalho Chehab [this message]
2017-12-12 14:21           ` Arnd Bergmann
2017-12-12 16:02             ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171212104530.46ac4ffe@vento.lan \
    --to=mchehab@kernel.org \
    --cc=arnd@arndb.de \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).