From: Greg KH <greg@kroah.com>
To: Vasyl Gomonovych <gomonovych@gmail.com>
Cc: sfr@canb.auug.org.au, arnd@arndb.de, sudeep.dutt@intel.com,
ashutosh.dixit@intel.com, dan.carpenter@oracle.com,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: [PATCH v2] misc: mic: Use memdup_user() as a cleanup
Date: Tue, 12 Dec 2017 12:49:37 +0100 [thread overview]
Message-ID: <20171212114937.GA23534@kroah.com> (raw)
In-Reply-To: <1513075258-10860-1-git-send-email-gomonovych@gmail.com>
On Tue, Dec 12, 2017 at 11:40:58AM +0100, Vasyl Gomonovych wrote:
> Fix coccicheck warning which recommends to use memdup_user():
>
> drivers/misc/mic/vop/vop_vringh.c:940:14-21: WARNING opportunity for memdup_user
> drivers/misc/mic/vop/vop_vringh.c:998:8-15: WARNING opportunity for memdup_user
>
> Generated by: scripts/coccinelle/memdup_user/memdup_user.cocci
>
> Changelog:
> - v1:
> - Replace kzalloc + copy_from_user on memdup_user
> - v2:
> - Clear forgotten done label
> After merging the char-misc tree, today's linux-next build
> (x86_64_allmodconfig) produced this warning:
> drivers/misc/mic/vop/vop_vringh.c: In function 'vop_ioctl':
> drivers/misc/mic/vop/vop_vringh.c:1001:1: warning: label 'done' defined but not used [-Wunused-label]
Will not work as I already have taken v1.
Also, put the changelog below the --- line please.
thanks,
greg k-h
next prev parent reply other threads:[~2017-12-12 11:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 3:39 linux-next: build warning after merge of the char-misc tree Stephen Rothwell
2017-12-12 10:40 ` [PATCH v2] misc: mic: Use memdup_user() as a cleanup Vasyl Gomonovych
2017-12-12 11:49 ` Greg KH [this message]
2017-12-12 13:22 ` Gomonovych, Vasyl
2017-12-13 9:30 ` Greg KH
2017-12-13 22:01 ` [PATCH v3] " Vasyl Gomonovych
2017-12-19 9:17 ` Greg KH
2017-12-12 11:49 ` linux-next: build warning after merge of the char-misc tree Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171212114937.GA23534@kroah.com \
--to=greg@kroah.com \
--cc=arnd@arndb.de \
--cc=ashutosh.dixit@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=gomonovych@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=sudeep.dutt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).