From: Cornelia Huck <cohuck@redhat.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org,
"Michael S . Tsirkin" <mst@redhat.com>,
weiping zhang <zhangweiping@didichuxing.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_mmio: fix devm cleanup
Date: Tue, 12 Dec 2017 14:31:48 +0100 [thread overview]
Message-ID: <20171212143148.4a022816.cohuck@redhat.com> (raw)
In-Reply-To: <20171212132902.t5vxs2yujsth2v2h@lakrids.cambridge.arm.com>
On Tue, 12 Dec 2017 13:29:02 +0000
Mark Rutland <mark.rutland@arm.com> wrote:
> On Tue, Dec 12, 2017 at 02:09:52PM +0100, Cornelia Huck wrote:
> > Shouldn't the cleanup in _remove() then be removed as well?
>
> Ah, I'd missed that.
>
> I believe that can be removed, yes.
>
> Should I spin a v2 with that folded in?
I think it has the same devm_ioremap vs. iounmap discrepancy, so it
should probably be folded in.
next prev parent reply other threads:[~2017-12-12 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 12:53 [PATCH] virtio_mmio: fix devm cleanup Mark Rutland
2017-12-12 13:09 ` Cornelia Huck
2017-12-12 13:29 ` Mark Rutland
2017-12-12 13:31 ` Cornelia Huck [this message]
2017-12-12 13:34 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171212143148.4a022816.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=zhangweiping@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).