From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753800AbdLMUFO (ORCPT ); Wed, 13 Dec 2017 15:05:14 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:44052 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752932AbdLMUFN (ORCPT ); Wed, 13 Dec 2017 15:05:13 -0500 Date: Wed, 13 Dec 2017 15:05:11 -0500 (EST) Message-Id: <20171213.150511.1299918610251349853.davem@davemloft.net> To: colin.king@canonical.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, carlo@caione.org, khilman@baylibre.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] net: phy: meson-gxl: make function meson_gxl_read_status static From: David Miller In-Reply-To: <20171212130311.17185-1-colin.king@canonical.com> References: <20171212130311.17185-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 Dec 2017 12:05:12 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Tue, 12 Dec 2017 13:03:11 +0000 > From: Colin Ian King > > The function meson_gxl_read_status is local to the source and does > not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'meson_gxl_read_status' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Applied.