From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752279AbdLMBtB (ORCPT <rfc822;w@1wt.eu>);
        Tue, 12 Dec 2017 20:49:01 -0500
Received: from mailout1.samsung.com ([203.254.224.24]:56216 "EHLO
        mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750886AbdLMBs6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Dec 2017 20:48:58 -0500
DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20171213014856epoutp0187697d80b99209cbd159d45fd91ae47d~-t3piWTTw2485224852epoutp01e
X-AuditID: b6c32a38-eddff70000001183-29-5a308707756f
Date: Wed, 13 Dec 2017 10:48:54 +0900
From: Andi Shyti <andi.shyti@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Philippe Ombredanne <pombredanne@nexb.com>,
        Andi Shyti <andi@etezian.org>, Kukjin Kim <kgene@kernel.org>,
        Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org,
        linux-samsung-soc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] spi: s3c64xx: add SPDX identifier
Message-id: <20171213014854.GG20051@gangnam.samsung>
MIME-version: 1.0
Content-type: text/plain; charset="us-ascii"
Content-disposition: inline
In-reply-to: <CAJKOXPeCBPdCi2NnpBWimb4Py_zDZrsSK9o1cCswKM+XNeyqxQ@mail.gmail.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpik+LIzCtJLcpLzFFi42LZdlhTX5e93SDK4OgedYvFP54zWUx9+ITN
        onnxejaL/sevmS3On9/AbnF51xw2ixnn9zFZNH68yW7x//c5VovNm6YyO3B5XF/yidlj06pO
        No93586xe+yfu4bdY/lOE4/Pm+QC2KJSbTJSE1NSixRS85LzUzLz0m2VvIPjneNNzQwMdQ0t
        LcyVFPISc1NtlVx8AnTdMnOALlNSKEvMKQUKBSQWFyvp29kU5ZeWpCpk5BeX2CpFGxoa6Rka
        mOsZGRnpmRjHWhmZApUkpGYcvW9cMIejoq/zPEsD4wy2LkZODgkBE4kdd34D2VwcQgI7GCVW
        Lp/KCOF8Z5SYfnoKI0zV1f2zoao2MErsPPUEyvnEKPHl4zNmkCoWAVWJYw8/soLYbAKaEk23
        f4DtEAGyr//9zgrSwCxwkUni0cUVTCAJYQEziQ/zL7F0MXJw8AKt6H7MCRLmFRCU+DH5HguI
        zSygI3H22DpGCFta4tHfGewgNqdAsMTng4/A9ooKKEvs7TvEDjJfQuA+m8SeRU/ZIc52kWjr
        fsEEYQtLvDq+hR1klwTQoEtHbSHCzYwS224nQ/ROYJT4tPcrVL2xxLOFXUwQi/kk3n3tYYXo
        5ZXoaBOCKPGQuPT6EjQcHSVOX9oLVi4k8JxF4s9k0wmMsrOQvDMLyTuzkLyzgJF5FaNYakFx
        bnpqsWGBiV5xYm5xaV66XnJ+7iZGcPrTstjBuOeczyFGAQ5GJR7ejnv6UUKsiWXFlbmHGCU4
        mJVEeHviDaKEeFMSK6tSi/Lji0pzUosPMZoCo2Qis5Rocj4wNeeVxBuaWBqYmBkBk5SloaGS
        OK/o+msRQgLpiSWp2ampBalFMH1MHJxSDYzmno7PxHVyL/wQq1DRylQPf+ks+Wth/iPdnS+f
        SdcJ/LpwMfyXhkUOy1kFM7fUWVsmnVJuDjy8JuLv0bfGAvPL/NjWnbjJt/CUl3+ErT5LSqNj
        4t6UaX/KRRs583y3SZ7zOf55leNP/ljpiH5ehxz2l5P6jshV1L0963T4wb2VQisen2+cJ6fE
        UpyRaKjFXFScCAA9X8Q4lQMAAA==
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsVy+t9jQV32doMogw1H+SwW/3jOZDH14RM2
        i+bF69ks+h+/ZrY4f34Du8XlXXPYLGac38dk0fjxJrvF/9/nWC02b5rK7MDlcX3JJ2aPTas6
        2TzenTvH7rF/7hp2j+U7TTw+b5ILYIvisklJzcksSy3St0vgyjh637hgDkdFX+d5lgbGGWxd
        jJwcEgImElf3zwayuTiEBNYxSvx+vpAVJCEk8IlR4u92RxCbRUBV4tjDj2BxNgFNiabbP8Ca
        RYDs63+/s4I0MwtcZJKY3LsTrEhYwEziw/xLLF2MHBy8QBu6H3NCLHjJIvGmdSI7SA2vgKDE
        j8n3WEBsZgEtifU7jzNB2NISj/7OAKvhFAiW2PLrFDOILSqgLLG37xD7BEb+WUjaZyFpn4Wk
        fQEj8ypGydSC4tz03GKjAsO81HK94sTc4tK8dL3k/NxNjMDQ33ZYq28H4/0l8YcYBTgYlXh4
        HzzQjxJiTSwrrsw9xCjBwawkwtsTbxAlxJuSWFmVWpQfX1Sak1p8iFGag0VJnPd23rFIIYH0
        xJLU7NTUgtQimCwTB6dUA6PW7QPT7inYPdWXyhXdtzWDoYLvxfadZW+3y93v2jHtk6bvK/Uk
        p/SVWs9mh8m0L+mpeP3Lzjpp4wcRk/qEG4emfmA0CV63rMyTe2VN1meZCd+nTvp9LFh+Zua6
        53vXn2Lc8fNgmN975Z1P/v7X/9PcuXqzuV/G2m8zhbOFju6MOSuanHlKVEhRiaU4I9FQi7mo
        OBEAZ3qI3HkCAAA=
X-CMS-MailID: 20171213014855epcas1p3c03cc202277b585e5902d0ad734fe687
X-Msg-Generator: CA
CMS-TYPE: 101P
DLP-Filter: Pass
X-CFilter-Loop: Reflected
X-CMS-RootMailID: 20171212075830epcas2p31afc4a2e715e857694082748fd2bbe49
X-RootMTR: 20171212075830epcas2p31afc4a2e715e857694082748fd2bbe49
References: <CGME20171212075830epcas2p31afc4a2e715e857694082748fd2bbe49@epcas2p3.samsung.com>
        <20171212075815.8683-1-andi.shyti@samsung.com>
        <CAJKOXPfdKyT8-bpM7tmveb3jWCRSSXwnkifhsRw_ag8X9z0W8A@mail.gmail.com>
        <20171212130313.GC1072@brancaleone.zhora.eu>
        <CAJKOXPc8o2_bMbXjwPopOtsoML0NqOzzHnYXCL9oU9VkU2cQYA@mail.gmail.com>
        <CAOFm3uHobATjskAKG83QoSQjXgzv1RQFv0vrgt_QgnZoxNQ2-w@mail.gmail.com>
        <CAJKOXPeZi=TWqoCo9x-Wa372ey8D=r8-Lf3CvJ95dgaMAF1kxQ@mail.gmail.com>
        <CAOFm3uEAzEgN-PgSOccbwO3aWfABsHywUmm8eXasR8CXy=NPJQ@mail.gmail.com>
        <CAJKOXPeCBPdCi2NnpBWimb4Py_zDZrsSK9o1cCswKM+XNeyqxQ@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Krzysztof,

> > Here, this should be as a top line:
> >
> > // SPDX-License-Identifier: GPL-2.0+
> >
> >
> > So I agree with the SPDX id but also pointing to the use of the C++ //
> > comment style as requested by Linus [1]
> 
> Thanks for the reference. I see that Linus prefers converting entire
> comment into // style. I was not arguing about SPDX line but entire
> existing copyright comment which follows it:
> 
> > +//
> > +// Copyright (c) 2009 Samsung Electronics Co., Ltd.
> > +//      Jaswinder Singh <jassi.brar@samsung.com>

it just looks ugly to me to have something like

  // SPDX...
  
  /*
   * Copyright (c)...
   *      Jasw...
   */

I would make everything of the '//' style (I've also seen that
this is the trend also in other subsystems), but honestly I don't
really care. If you're strong on not moving entirely in '//' style
then I can resend it with the double comment style.

Andi

P.S. About GPLv2 vs GPLv2+ I checked and I will repost it keeping
the license as its original. Thanks!