From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752320AbdLMJSm (ORCPT <rfc822;w@1wt.eu>);
        Wed, 13 Dec 2017 04:18:42 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:51054 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751459AbdLMJSU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Dec 2017 04:18:20 -0500
Date: Wed, 13 Dec 2017 10:18:22 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
        ALSA <alsa-devel@alsa-project.org>, Mark <broonie@kernel.org>,
        Takashi <tiwai@suse.de>, Pierre <pierre-louis.bossart@linux.intel.com>,
        patches.audio@intel.com, alan@linux.intel.com,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        Sagar Dharia <sdharia@codeaurora.org>, srinivas.kandagatla@linaro.org,
        plai@codeaurora.org, Sudheer Papothi <spapothi@codeaurora.org>
Subject: Re: [PATCH v5 00/15] soundwire: Add a new SoundWire subsystem
Message-ID: <20171213091822.GD6269@kroah.com>
References: <1512575231-4154-1-git-send-email-vinod.koul@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1512575231-4154-1-git-send-email-vinod.koul@intel.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 06, 2017 at 09:16:56PM +0530, Vinod Koul wrote:
> This patch series adds a new SoundWire subsystem which implements a
> new MIPI bus protocol 'SoundWire'.
> 
> The SoundWire protocol is a robust, scalable, low complexity, low
> power, low latency, two-pin (clock and data) multi-drop bus that
> allows for the transfer of multiple audio streams and embedded
> control/commands.  SoundWire provides synchronization capabilities
> and supports both PCM and PDM, multichannel data, isochronous and
> asynchronous modes.
> 
> This series adds SoundWire Bus, IO transfers, DisCo (Discovery and
> Configuration) sysfs interface, regmap and Documentation summary
> 
> This patch series is also available on
> git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire.git topic/patch_v5
> 
> v4: https://lkml.org/lkml/2017/12/1/205
> v3: https://lkml.org/lkml/2017/11/30/160
> v2: https://lkml.org/lkml/2017/11/10/216
> v1: https://lkml.org/lkml/2017/10/18/1030
> RFC: https://lkml.org/lkml/2016/10/21/395

I don't think patch 5 is right, how you are using kobjects.

Also, you have to have some documentation on your userspace API here for
it to be reviewable.  To hide sysfs trees and files in code comments is
not good.

thanks,

greg k-h