From: Vinod Koul <vinod.koul@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
ALSA <alsa-devel@alsa-project.org>, Mark <broonie@kernel.org>,
Takashi <tiwai@suse.de>,
Pierre <pierre-louis.bossart@linux.intel.com>,
patches.audio@intel.com, alan@linux.intel.com,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Sagar Dharia <sdharia@codeaurora.org>,
srinivas.kandagatla@linaro.org, plai@codeaurora.org,
Sudheer Papothi <spapothi@codeaurora.org>
Subject: Re: [PATCH v5 00/15] soundwire: Add a new SoundWire subsystem
Date: Wed, 13 Dec 2017 15:27:46 +0530 [thread overview]
Message-ID: <20171213095746.GP18649@localhost> (raw)
In-Reply-To: <20171213091822.GD6269@kroah.com>
On Wed, Dec 13, 2017 at 10:18:22AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Dec 06, 2017 at 09:16:56PM +0530, Vinod Koul wrote:
> > This patch series adds a new SoundWire subsystem which implements a
> > new MIPI bus protocol 'SoundWire'.
> >
> > The SoundWire protocol is a robust, scalable, low complexity, low
> > power, low latency, two-pin (clock and data) multi-drop bus that
> > allows for the transfer of multiple audio streams and embedded
> > control/commands. SoundWire provides synchronization capabilities
> > and supports both PCM and PDM, multichannel data, isochronous and
> > asynchronous modes.
> >
> > This series adds SoundWire Bus, IO transfers, DisCo (Discovery and
> > Configuration) sysfs interface, regmap and Documentation summary
> >
> > This patch series is also available on
> > git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire.git topic/patch_v5
> >
> > v4: https://lkml.org/lkml/2017/12/1/205
> > v3: https://lkml.org/lkml/2017/11/30/160
> > v2: https://lkml.org/lkml/2017/11/10/216
> > v1: https://lkml.org/lkml/2017/10/18/1030
> > RFC: https://lkml.org/lkml/2016/10/21/395
>
> I don't think patch 5 is right, how you are using kobjects.
>
> Also, you have to have some documentation on your userspace API here for
> it to be reviewable. To hide sysfs trees and files in code comments is
> not good.
Ah I meant to do that but never got to it, sorry for that. I think I can
drop that patch for now, and we can merge rest of the stuff.
I will come back with sysfs files along with ABI documentation and fix it
per the discussion.
Thanks for the review and Acks
--
~Vinod
prev parent reply other threads:[~2017-12-13 9:54 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 15:46 [PATCH v5 00/15] soundwire: Add a new SoundWire subsystem Vinod Koul
2017-12-06 15:46 ` [PATCH v5 01/15] Documentation: Add SoundWire summary Vinod Koul
2017-12-06 15:46 ` [PATCH v5 02/15] soundwire: Add SoundWire bus type Vinod Koul
2017-12-13 9:16 ` Greg Kroah-Hartman
2017-12-06 15:46 ` [PATCH v5 03/15] soundwire: Add Master registration Vinod Koul
2017-12-11 16:02 ` Takashi Iwai
2017-12-11 16:44 ` [alsa-devel] " Vinod Koul
2017-12-13 9:16 ` Greg Kroah-Hartman
2017-12-06 15:47 ` [PATCH v5 04/15] soundwire: Add MIPI DisCo property helpers Vinod Koul
2017-12-11 16:10 ` Takashi Iwai
2017-12-11 17:00 ` Vinod Koul
2017-12-11 17:06 ` Takashi Iwai
2017-12-11 17:18 ` Vinod Koul
2017-12-06 15:47 ` [PATCH v5 05/15] soundwire: Add SoundWire MIPI defined registers Vinod Koul
2017-12-06 15:47 ` [PATCH v5 06/15] soundwire: Add IO transfer Vinod Koul
2017-12-06 15:47 ` [PATCH v5 07/15] regmap: Add SoundWire bus support Vinod Koul
2017-12-06 15:47 ` [PATCH v5 08/15] soundwire: Add Slave status handling helpers Vinod Koul
2017-12-06 15:47 ` [PATCH v5 09/15] soundwire: Add slave status handling Vinod Koul
2017-12-06 15:47 ` [PATCH v5 10/15] soundwire: Add sysfs for SoundWire DisCo properties Vinod Koul
2017-12-13 9:15 ` Greg Kroah-Hartman
2017-12-13 9:54 ` Vinod Koul
2017-12-13 14:31 ` Pierre-Louis Bossart
2017-12-13 16:28 ` Greg Kroah-Hartman
2017-12-13 16:52 ` [alsa-devel] " Vinod Koul
2017-12-13 16:59 ` Greg Kroah-Hartman
2017-12-22 8:26 ` Vinod Koul
2017-12-22 8:33 ` Greg Kroah-Hartman
2017-12-22 11:43 ` Vinod Koul
2017-12-22 15:20 ` Greg Kroah-Hartman
2017-12-06 15:47 ` [PATCH v5 11/15] soundwire: cdns: Add cadence library Vinod Koul
2017-12-06 15:47 ` [PATCH v5 12/15] soundwire: cdns: Add sdw_master_ops and IO transfer support Vinod Koul
2017-12-06 15:47 ` [PATCH v5 13/15] soundwire: intel: Add Intel Master driver Vinod Koul
2017-12-06 15:47 ` [PATCH v5 14/15] soundwire: intel: Add Intel init module Vinod Koul
2017-12-06 15:47 ` [PATCH v5 15/15] MAINTAINERS: Add SoundWire entry Vinod Koul
2017-12-06 20:44 ` [PATCH v5 00/15] soundwire: Add a new SoundWire subsystem Philippe Ombredanne
2017-12-07 0:38 ` Pierre-Louis Bossart
2017-12-11 16:30 ` Takashi Iwai
2017-12-13 9:18 ` Greg Kroah-Hartman
2017-12-13 9:57 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213095746.GP18649@localhost \
--to=vinod.koul@intel.com \
--cc=alan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches.audio@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=plai@codeaurora.org \
--cc=sdharia@codeaurora.org \
--cc=spapothi@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).