From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL for v4.15-rc3] media fixes
Date: Wed, 13 Dec 2017 10:36:20 -0200 [thread overview]
Message-ID: <20171213103620.6e34c124@vento.lan> (raw)
In-Reply-To: <CAMuHMdV2gKwwDggOwqqXSGDowJNhxxyT9CJuBfFB3LUHZBYE-A@mail.gmail.com>
Em Wed, 13 Dec 2017 13:27:47 +0100
Geert Uytterhoeven <geert@linux-m68k.org> escreveu:
> Hi Mauro,
>
> On Wed, Dec 13, 2017 at 12:53 PM, Mauro Carvalho Chehab
> <mchehab@osg.samsung.com> wrote:
> > Em Wed, 13 Dec 2017 10:03:56 +0100
> > Geert Uytterhoeven <geert@linux-m68k.org> escreveu:
> >> On Mon, Dec 11, 2017 at 12:12 PM, Mauro Carvalho Chehab
> >> <mchehab@osg.samsung.com> wrote:
> >> > Without this series, I was getting 809 lines of bogus warnings (see below),
> >> > with was preventing me to see new warnings on my incremental builds
> >> > while applying new patches at the media tree.
> >>
> >> $ linux-log-diff build.log{.old,}
> >>
> >> (from https://github.com/geertu/linux-scripts)
> >
> > That's nice!
> >
> > Yet, it is producing some noise. I did a clean build with:
> >
> > $ make ARCH=i386 CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y W=1 CHECK='' M=drivers/staging/media | grep -v -e " CC " -e " LD " -e " AR " -e " CHK " -e " CALL " -e " UPD " -e "scripts/kconfig/conf " -e " CHECK " >old.log
> > $ make ARCH=i386 CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y W=1 CHECK='' M=drivers/media| grep -v -e " CC " -e " LD " -e " AR " -e " CHK " -e " CALL " -e " UPD " -e "scripts/kconfig/conf " -e " CHECK " >>old.log
> >
> > and added a new uninitialized "foo" var to a random driver, doing an
> > incremental build with:
> >
> > $ make ARCH=i386 CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y W=1 CHECK='' | grep -v -e " CC " -e " LD " -e " AR " -e " CHK " -e " CALL " -e " UPD " -e "scripts/kconfig/conf " -e " CHECK " M=drivers/staging/media >new.log
> > $ make ARCH=i386 CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y W=1 CHECK='' | grep -v -e " CC " -e " LD " -e " AR " -e " CHK " -e " CALL " -e " UPD " -e "scripts/kconfig/conf " -e " CHECK " M=drivers/media >new.log
> >
> > Then, I ran the script:
> >
> > $ linux-log-diff old.log new.log
> >
> > *** ERRORS ***
> >
> >
> > *** WARNINGS ***
> >
> > 1 warning regressions:
> > + drivers/media/dvb-frontends/dibx000_common.c: warning: unused variable 'foo' [-Wunused-variable]: => 22:5
> >
> > 3 warning improvements:
> > - ./arch/x86/include/asm/bitops.h: warning: asm output is not an lvalue: 430:22 =>
> > - drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/mmu_private.h: warning: function 'mmu_reg_load' with external linkage has definition: 35:30 =>
> > - drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/mmu_private.h: warning: function 'mmu_reg_store' with external linkage has definition: 24:26 =>
> >
> > It detected the "foo" var warning, but it outputs 3 warning improvements
> > on files that were not even built the second time.
>
> If the file wasn't built, the warning cannot be in the log ;-)
> So yes, it works best for full builds, only flagging warnings that
> (dis)appeared (and ignoring changes due to changed line numbers!).
>
> If you do lots of incremental builds, you want to append the last incremental
> log to the existing full log before doing a new build, to avoid false positives
> from files that weren't built in the previous run:
>
> $ cat new.log >> old.log
> $ make ... > new.log
> $ linux-log-diff old.log new.log
>
> And only new warnings should be reported.
Ok. I'll do some trials with this script, as it sounds promising!
Regards,
Mauro
--
Thanks,
Mauro
prev parent reply other threads:[~2017-12-13 12:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 15:56 [GIT PULL for v4.15-rc3] media fixes Mauro Carvalho Chehab
2017-12-08 21:28 ` Linus Torvalds
2017-12-11 11:12 ` Mauro Carvalho Chehab
2017-12-13 9:03 ` Geert Uytterhoeven
2017-12-13 11:53 ` Mauro Carvalho Chehab
2017-12-13 12:27 ` Geert Uytterhoeven
2017-12-13 12:36 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213103620.6e34c124@vento.lan \
--to=mchehab@osg.samsung.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).