From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751577AbdLNAec (ORCPT ); Wed, 13 Dec 2017 19:34:32 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:43070 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbdLNAea (ORCPT ); Wed, 13 Dec 2017 19:34:30 -0500 X-Google-Smtp-Source: ACJfBouDWXPlWIrxz/A+u9oJXmTeiRMbfPeywluzmMbXhgImHqzKD1IZPzJSM6cmGe9fy6Kd52PXug== Date: Wed, 13 Dec 2017 16:34:27 -0800 From: Bjorn Andersson To: Loic Pallardy Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, arnaud.pouliquen@st.com, benjamin.gaignard@linaro.org Subject: Re: [PATCH v2 02/16] remoteproc: add release ops in rproc_mem_entry struct Message-ID: <20171214003427.GD17344@builder> References: <1512060411-729-1-git-send-email-loic.pallardy@st.com> <1512060411-729-3-git-send-email-loic.pallardy@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512060411-729-3-git-send-email-loic.pallardy@st.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 30 Nov 08:46 PST 2017, Loic Pallardy wrote: > +static int rproc_release_carveout(struct rproc *rproc, struct rproc_mem_entry *mem) > +{ > + struct device *dev = &rproc->dev; > + > + /* clean up carveout allocations */ > + dma_free_coherent(dev->parent, mem->len, mem->va, mem->dma); > + list_del(&mem->node); The core is responsible for putting the node on a list, so let the cleanup take if off the list. > + kfree(mem); > + return 0; > +} > + [..] > @@ -319,12 +322,11 @@ struct rproc_mem_entry { > dma_addr_t dma; > int len; > u32 da; > + int (*release)(struct rproc *rproc, struct rproc_mem_entry *mem); The placement here seems random, please move it last in the struct. > void *priv; > struct list_head node; > }; > Regards, Bjorn