From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756258AbdLOTZR (ORCPT ); Fri, 15 Dec 2017 14:25:17 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:46724 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755419AbdLOTZP (ORCPT ); Fri, 15 Dec 2017 14:25:15 -0500 Date: Fri, 15 Dec 2017 20:25:17 +0100 From: Greg Kroah-Hartman To: Ludovic Barre Cc: Jiri Slaby , Rob Herring , Maxime Coquelin , Alexandre Torgue , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] serial: stm32: add default console Message-ID: <20171215192517.GA27395@kroah.com> References: <1512146211-29086-1-git-send-email-ludovic.Barre@st.com> <1512146211-29086-2-git-send-email-ludovic.Barre@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512146211-29086-2-git-send-email-ludovic.Barre@st.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 01, 2017 at 05:36:50PM +0100, Ludovic Barre wrote: > From: Ludovic Barre > > This patch adds by default the console support > on stm32. Why? 'default y' should only mean "machine will not boot without this". And I think your machine will boot without the console, right? :) thanks, greg k-h